8298303: (fs) temporarily remove Path.getExtension

[bplb]

Remove java.nio.file.Path::getExtension from the JDK 20 mainline to allow its definition time to settle.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8298303: (fs) temporarily remove Path.getExtension
• JDK-8298305: (fs) temporarily remove Path.getExtension (CSR)

Reviewers

• Stuart Marks (@stuart-marks - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11566/head:pull/11566
$ git checkout pull/11566

Update a local copy of the PR:
$ git checkout pull/11566
$ git pull https://git.openjdk.org/jdk pull/11566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11566

View PR using the GUI difftool:
$ git pr show -t 11566

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11566.diff

[bplb]

/csr

[stuart-marks]

Looks like a straightforward backout of relevant code and doc comments from JDK-8057113.

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298303: (fs) temporarily remove Path.getExtension

Reviewed-by: smarks, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• 8edb98d: 8165943: LineBreakMeasurer does not measure correctly if TextAttribute.TRACKING is set.
• 3934484: 8298205: Prefer Member Initialization Lists for JFR classes in os_perf.hpp
• 389b8f4: 8297298: SequenceInputStream should override transferTo
• dd7385d: 8298202: [AIX] Dead code elimination removed jfr constructor used by AIX
• 29f1c3c: 8298274: Problem list TestSPISigned on Windows
• 3de7750: 8298177: Various java.lang.invoke cleanups
• 6ed3683: 8297209: Serial: Refactor GenCollectedHeap::full_process_roots
• 86270e3: 8269820: C2 PhaseIdealLoop::do_unroll get wrong opaque node
• cf63f2e: 8298184: Incorrect record component type in record patterns
• 58170f6: 8298035: Provide better descriptions for JIT compiler JFR events
• ... and 41 more: https://git.openjdk.org/jdk/compare/8af6e8a67fc0355f11c270c3ea794366741856fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@bplb please create a CSR request for issue JDK-8298303 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8ab01152)

[bplb]

/integrate

[openjdk]

Going to push as commit 10356e7.
Since your change was applied there have been 53 commits pushed to the master branch:

• 3b8c7ef: 8157023: Integrate NMT with JFR
• e86f31b: 8298301: C2: assert(main_cmp->in(2)->Opcode() == Op_Opaque1) failed: main loop has no opaque node?
• 8edb98d: 8165943: LineBreakMeasurer does not measure correctly if TextAttribute.TRACKING is set.
• 3934484: 8298205: Prefer Member Initialization Lists for JFR classes in os_perf.hpp
• 389b8f4: 8297298: SequenceInputStream should override transferTo
• dd7385d: 8298202: [AIX] Dead code elimination removed jfr constructor used by AIX
• 29f1c3c: 8298274: Problem list TestSPISigned on Windows
• 3de7750: 8298177: Various java.lang.invoke cleanups
• 6ed3683: 8297209: Serial: Refactor GenCollectedHeap::full_process_roots
• 86270e3: 8269820: C2 PhaseIdealLoop::do_unroll get wrong opaque node
• ... and 43 more: https://git.openjdk.org/jdk/compare/8af6e8a67fc0355f11c270c3ea794366741856fa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 10356e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.