Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298277: Replace "session" with "scope" for FFM access #11573

Closed
wants to merge 2 commits into from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Dec 7, 2022

This PR suggests renaming various names from "session" to "scope" in accordance with https://openjdk.org/jeps/434

The PRs contains changes for several sub-components.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298277: Replace "session" with "scope" for FFM access

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11573/head:pull/11573
$ git checkout pull/11573

Update a local copy of the PR:
$ git checkout pull/11573
$ git pull https://git.openjdk.org/jdk pull/11573/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11573

View PR using the GUI difftool:
$ git pr show -t 11573

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11573.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2022

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@minborg The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot
  • net
  • nio
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org nio nio-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org net net-dev@openjdk.org labels Dec 7, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2022

Webrevs

*/
public abstract sealed class MemorySessionImpl
public abstract sealed class MemoryScopeImpl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the interface is called SegmentScope, I think SegmentScopeImpl would be a better name here.

@mcimadamore
Copy link
Contributor

mcimadamore commented Dec 7, 2022

I think we should split this PR into multiple parts:

  • there are some good javadoc changes in here to the Vector API docs;
  • there are some test changes, where some of the names are out of date;
  • there are some implementation names mismatches e.g. SegmentScope session - which would better be fixed;
  • the majority of changes, which is caused by MemorySessionImpl -> MemoryScopeImpl is the part I'm less sure about. I think leaving that as is might be fine for now

@minborg minborg marked this pull request as draft December 8, 2022 10:16
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 8, 2022
@minborg
Copy link
Contributor Author

minborg commented Dec 8, 2022

I am going to close this PR in favor of several other smaller ones.

@minborg minborg closed this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org net net-dev@openjdk.org nio nio-dev@openjdk.org security security-dev@openjdk.org
3 participants