8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx #11576

plummercj · 2022-12-08T03:06:31Z

This fixes two separate CRs:

JDK-8241293 CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes
JDK-8298073 gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx

For the first one the test was hitting an 8m timeout, but completing right after that. The test log said PASSED, but jtreg failed it anyway because it noticed the timeout. The fix is to double the default 120s timeout to 240s (which is 16m when the 4x timeoutfactor is applied.

For the second one the issue seemed to be with having the test process spawn a jhsdb process that attached back to the test process. OSX didn't seem to be too happy about this. The fix is to instead create a LingeredApp process to attach to like all the other SA tests do.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issues

JDK-8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx
JDK-8241293: CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes

Reviewers

Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to e1543d5a
Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to b403e129

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11576/head:pull/11576
$ git checkout pull/11576

Update a local copy of the PR:
$ git checkout pull/11576
$ git pull https://git.openjdk.org/jdk pull/11576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11576

View PR using the GUI difftool:
$ git pr show -t 11576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11576.diff

plummercj · 2022-12-08T03:07:12Z

/issue JDK-8241293

bridgekeeper · 2022-12-08T03:08:47Z

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-12-08T03:12:44Z

@plummercj
Adding additional issue to issue list: 8241293: CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes.

openjdk · 2022-12-08T03:15:44Z

@plummercj The following label will be automatically applied to this pull request:

hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-12-08T03:18:41Z

Webrevs

plummercj · 2022-12-08T07:08:40Z

/label serviceability

openjdk · 2022-12-08T07:10:38Z

@plummercj
The serviceability label was successfully added.

plummercj · 2022-12-08T15:52:59Z

Ping. Trying to trigger email to serviceability-dev.

openjdk · 2022-12-08T17:46:36Z

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx
8241293: CompressedClassSpaceSizeInJmapHeap.java time out after 8 minutes

Reviewed-by: ayang, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

7f9c6ce: 8297679: InvocationTargetException field named target is not declared final
5540a8c: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working
c16eb89: 8298138: Shenandoah: HdrSeq asserts "sub-bucket index (512) overflow for value ( 1.00)"
3dfadee: 8292289: [vectorapi] Improve the implementation of VectorTestNode
d35e840: 8297295: Remove ThreadGroup.allowThreadSuspension
175e3d3: 8296149: Start of release updates for JDK 21
d562d3f: 8297642: PhaseIdealLoop::only_has_infinite_loops must detect all loops that never lead to termination
fc52f21: 8298255: JFR provide information about dynamization of number of compiler threads
e555d54: 8298383: JFR: GenerateJfrFiles.java lacks copyright header
c084431: 8298379: JFR: Some UNTIMED events only sets endTime
... and 15 more: https://git.openjdk.org/jdk/compare/74f346b33f7fa053ad5c99ef85baa32b7fb12fa6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java

…Heap.java Delete extra space. Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>

sspitsyn

Looks good.
Thanks,
Serguei

sspitsyn · 2022-12-09T02:50:17Z

test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java

@@ -32,10 +32,11 @@
 * @library /test/lib
 * @modules java.base/jdk.internal.misc
 *          java.management
- * @run main/othervm -XX:CompressedClassSpaceSize=48m gc.metaspace.CompressedClassSpaceSizeInJmapHeap
+ * @run main/timeout=240  gc.metaspace.CompressedClassSpaceSizeInJmapHeap


Nit: unneeded space after 240.

test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java

…Heap.java Remove extra space.

plummercj · 2022-12-09T18:40:03Z

Thanks for the reviews!

/integrate

openjdk · 2022-12-09T18:42:43Z

Going to push as commit 99a6c47.
Since your change was applied there have been 33 commits pushed to the master branch:

f729f5b: 8298298: NMT: count deltas are printed with 32-bit signed size
9346535: 8298320: Typo in the comment block of catch_inline_exception
b30b464: 8297036: Generalize C2 stub mechanism
05b0a01: 8298281: Serial: Refactor MarkAndPushClosure
e3c6cf8: 8298380: Clean up redundant array length checks in JDK code base
33d955a: 8298345: Fix another two C2 IR matching tests for RISC-V
cb766c5: 8297778: Modernize and improve module jdk.sctp
11aece2: 8257197: Add additional verification code to PhaseCCP
7f9c6ce: 8297679: InvocationTargetException field named target is not declared final
5540a8c: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working
... and 23 more: https://git.openjdk.org/jdk/compare/74f346b33f7fa053ad5c99ef85baa32b7fb12fa6...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-12-09T18:43:05Z

@plummercj Pushed as commit 99a6c47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Attach to LingeredApp process rather than to the test process.

124b9c0

Fix indent.

e1543d5

openjdk bot changed the title ~~8298073~~ 8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx Dec 8, 2022

openjdk bot added the rfr Pull request is ready for review label Dec 8, 2022

openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 8, 2022

openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 8, 2022

albertnetymk approved these changes Dec 8, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2022

turbanoff reviewed Dec 8, 2022

View reviewed changes

test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java Outdated Show resolved Hide resolved

Update test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmap…

b403e12

…Heap.java Delete extra space. Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>

sspitsyn approved these changes Dec 9, 2022

View reviewed changes

plummercj commented Dec 9, 2022

View reviewed changes

test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java Outdated Show resolved Hide resolved

Update test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmap…

8002eae

…Heap.java Remove extra space.

openjdk bot added the integrated Pull request has been integrated label Dec 9, 2022

openjdk bot closed this Dec 9, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx #11576

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx #11576

plummercj commented Dec 8, 2022 •

edited by openjdk bot

Loading

plummercj commented Dec 8, 2022

bridgekeeper bot commented Dec 8, 2022

openjdk bot commented Dec 8, 2022

openjdk bot commented Dec 8, 2022

mlbridge bot commented Dec 8, 2022 •

edited

Loading

plummercj commented Dec 8, 2022

openjdk bot commented Dec 8, 2022

plummercj commented Dec 8, 2022

openjdk bot commented Dec 8, 2022 •

edited

Loading

sspitsyn left a comment

sspitsyn Dec 9, 2022

plummercj commented Dec 9, 2022

openjdk bot commented Dec 9, 2022

openjdk bot commented Dec 9, 2022

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx #11576

8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx #11576

Conversation

plummercj commented Dec 8, 2022 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

plummercj commented Dec 8, 2022

bridgekeeper bot commented Dec 8, 2022

openjdk bot commented Dec 8, 2022

openjdk bot commented Dec 8, 2022

mlbridge bot commented Dec 8, 2022 • edited Loading

Webrevs

plummercj commented Dec 8, 2022

openjdk bot commented Dec 8, 2022

plummercj commented Dec 8, 2022

openjdk bot commented Dec 8, 2022 • edited Loading

sspitsyn left a comment

Choose a reason for hiding this comment

sspitsyn Dec 9, 2022

Choose a reason for hiding this comment

plummercj commented Dec 9, 2022

openjdk bot commented Dec 9, 2022

openjdk bot commented Dec 9, 2022

plummercj commented Dec 8, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 8, 2022 •

edited

Loading

openjdk bot commented Dec 8, 2022 •

edited

Loading