Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298383: JFR: GenerateJfrFiles.java lacks copyright header #11591

Closed
wants to merge 2 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Dec 8, 2022

Could I have a review of a PR that adds missing copyright header to GenerateJfrFiles.java

Testing: tier1

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298383: JFR: GenerateJfrFiles.java lacks copyright header

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11591/head:pull/11591
$ git checkout pull/11591

Update a local copy of the PR:
$ git checkout pull/11591
$ git pull https://git.openjdk.org/jdk pull/11591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11591

View PR using the GUI difftool:
$ git pr show -t 11591

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11591.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2022

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@egahlin The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Dec 8, 2022
@egahlin egahlin marked this pull request as ready for review December 8, 2022 13:41
@egahlin egahlin marked this pull request as draft December 8, 2022 13:43
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2022
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 8, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2022

Webrevs

@egahlin egahlin marked this pull request as ready for review December 8, 2022 14:09
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298383: JFR: GenerateJfrFiles.java lacks copyright header

Reviewed-by: mgronlun, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ea108f5: 8298129: Let checkpoint event sizes grow beyond u4 limit
  • 165dcdd: 8297718: Make NMT free:ing protocol more granular

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2022
@egahlin
Copy link
Member Author

egahlin commented Dec 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2022

Going to push as commit e555d54.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c084431: 8298379: JFR: Some UNTIMED events only sets endTime
  • ea108f5: 8298129: Let checkpoint event sizes grow beyond u4 limit
  • 165dcdd: 8297718: Make NMT free:ing protocol more granular

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 8, 2022
@openjdk openjdk bot closed this Dec 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2022
@openjdk
Copy link

openjdk bot commented Dec 8, 2022

@egahlin Pushed as commit e555d54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants