8298379: JFR: Some UNTIMED events only sets endTime

[mgronlun]

Greetings,

It was pointed out that some UNTIMED events only call set_endtime(), and not the corresponding set_starttime(), for example some events in jfrPeriodic.cpp. UNTIMED events need to have both timestamps set, because the UNTIMED parameter denotes that the user takes on the responsibility for controlling time stamping.

This change rectifies a few places by adding the corresponding set_starttime() call.

Test: jdk_jfr

Thanks
Markus

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298379: JFR: Some UNTIMED events only sets endTime

Reviewers

• Erik Helin (@edvbld - Reviewer) ⚠️ Review applies to f1acc1f5
• Erik Gahlin (@egahlin - Reviewer) ⚠️ Review applies to f1acc1f5

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11592/head:pull/11592
$ git checkout pull/11592

Update a local copy of the PR:
$ git checkout pull/11592
$ git pull https://git.openjdk.org/jdk pull/11592/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11592

View PR using the GUI difftool:
$ git pr show -t 11592

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11592.diff

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (556931f5)
• 02: Full - Incremental (f1acc1f5)
• 01: Full - Incremental (2407c6cf)
• 00: Full (3dfa329f)

[edvbld]

Looks good, thanks @mgronlun for fixing!

[openjdk]

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298379: JFR: Some UNTIMED events only sets endTime

Reviewed-by: ehelin, egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mgronlun]

Thanks @ehelin for reporting and reviewing this!

[mgronlun]

/integrate

[openjdk]

Going to push as commit c084431.

[openjdk]

@mgronlun Pushed as commit c084431.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.