8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

[jerboaa]

The test introduced with JDK-8298108 failed on Windows apparently due to a non-portable use of path.separator in the test.

@seanjmullan was kind enough to test this change, which fixes the issue on Windows.

Thus, remove the test from the ProblemList.txt as the test now works on that platform as well. Thoughts?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11606/head:pull/11606
$ git checkout pull/11606

Update a local copy of the PR:
$ git checkout pull/11606
$ git pull https://git.openjdk.org/jdk pull/11606/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11606

View PR using the GUI difftool:
$ git pr show -t 11606

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11606.diff

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jerboaa The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4806afac)

[seanjmullan]

I tested the fix on all platforms and it passed. This is probably also worth fixing in JDK 20 to get it off the ProblemList.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

• b30b464: 8297036: Generalize C2 stub mechanism
• 05b0a01: 8298281: Serial: Refactor MarkAndPushClosure
• e3c6cf8: 8298380: Clean up redundant array length checks in JDK code base
• 33d955a: 8298345: Fix another two C2 IR matching tests for RISC-V
• cb766c5: 8297778: Modernize and improve module jdk.sctp
• 11aece2: 8257197: Add additional verification code to PhaseCCP
• 7f9c6ce: 8297679: InvocationTargetException field named target is not declared final
• 5540a8c: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working
• c16eb89: 8298138: Shenandoah: HdrSeq asserts "sub-bucket index (512) overflow for value ( 1.00)"
• 3dfadee: 8292289: [vectorapi] Improve the implementation of VectorTestNode
• ... and 31 more: https://git.openjdk.org/jdk/compare/39344840c7a5fbd37f6c6a972a89c3600396e878...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

I tested the fix on all platforms and it passed. This is probably also worth fixing in JDK 20 to get it off the ProblemList.

Thanks for the review! What does fixing in JDK 20 mean at this stage? File a PR against https://github.com/openjdk/jdk20 instead?

[seanjmullan]

I tested the fix on all platforms and it passed. This is probably also worth fixing in JDK 20 to get it off the ProblemList.

Thanks for the review! What does fixing in JDK 20 mean at this stage? File a PR against https://github.com/openjdk/jdk20 instead?

Yes, and you can use the skara backport command to make this easier. See https://openjdk.org/guide/#using-the-skara-tooling-to-help-with-backports

[jerboaa]

I tested the fix on all platforms and it passed. This is probably also worth fixing in JDK 20 to get it off the ProblemList.

Thanks for the review! What does fixing in JDK 20 mean at this stage? File a PR against https://github.com/openjdk/jdk20 instead?

Yes, and you can use the skara backport command to make this easier. See https://openjdk.org/guide/#using-the-skara-tooling-to-help-with-backports

Now I'm confused. Aren't changes done to jdk20 automatically merged to the JDK 21 (jdk head) tree? Why would I use backport tooling. Or are you suggesting to integrate this and then backport to the jdk20 tree?

[jerboaa]

Withdrawing this PR in favour of openjdk/jdk20#18 to get it into JDK 20 instead (during RDP1).