7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected

[bplb]

Add a sentence to clarify that coding exceptions are not thrown until the characters are actually written to the underlying stream.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected
• JDK-8298609: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected (CSR)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11616/head:pull/11616
$ git checkout pull/11616

Update a local copy of the PR:
$ git checkout pull/11616
$ git pull https://git.openjdk.org/jdk pull/11616/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11616

View PR using the GUI difftool:
$ git pr show -t 11616

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11616.diff

[bplb]

/csr

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@bplb please create a CSR request for issue JDK-7093322 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b683c914)
• 01: Full - Incremental (20369045)
• 00: Full (c0fda10f)

[AlanBateman]

Thanks for the update, the text is good now. You might want to bring back the links to write, flush and close as you had in the first version.

[bplb]

Thanks for the update, the text is good now. You might want to bring back the links to write, flush and close as you had in the first version.

Links restore in b683c91.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• 6802277: 8298524: Debug function to trace reachability of CDS archived heap objects
• 23e1827: Merge
• 04b8d0c: 8298084: Memory leak in Method::build_profiling_method_data
• d453190: 8296955: Kitchensink.java failed with "double free or corruption (!prev): "
• 8962c72: 8298488: [macos13] tools/jpackage tests failing with "Exit code: 137" on macOS
• 0267aa5: 8297288: Example code in Scanner class
• cf93933: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows
• d624deb: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation
• 042b706: 8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax
• 4081bba: 8297960: G1: Move Root Region Scan Waiting outside collection in logs
• ... and 29 more: https://git.openjdk.org/jdk/compare/7dbdd83da0eefd56927bdb68d7aedfee5c0c0ab5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 831b35f.
Since your change was applied there have been 76 commits pushed to the master branch:

• 0288210: 8298859: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all
• b17c524: 8298059: Linked stack watermarks don't support nesting
• 98fa48c: 8298093: improve cleanup and error handling of awt_parseColorModel in awt_parseImage.c
• 5f63f7a: 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds
• 3ae7187: 8298498: sun/net/www/http/KeepAliveCache/B8291637.java fails with "Server exception terminating: java.net.SocketException: Socket closed"
• b9074fa: 8298249: Excessive memory allocation in CipherInputStream AEAD decryption
• 10bc86c: Merge
• 80cadd4: 8298785: gc/TestFullGCCount.java fails with "invalid boolean value: null' for expression vm.opt.ExplicitGCInvokesConcurrent'"
• ebc4710: 8298277: Replace "session" with "scope" for FFM access
• d1085d1: 8281946: VM.native_memory should report size of shareable memory
• ... and 66 more: https://git.openjdk.org/jdk/compare/7dbdd83da0eefd56927bdb68d7aedfee5c0c0ab5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 831b35f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.