Skip to content

8298568: Fastdebug build fails after JDK-8296389 #11631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Dec 12, 2022

This is a trivial change fixing a typo introduced by JDK-8296389.

The correct version is "is_NeverBranch()" instead of "isNeverBranch()".

Testing: Fastdebug builds fine with this fix on linux-aarch64 platform.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11631/head:pull/11631
$ git checkout pull/11631

Update a local copy of the PR:
$ git checkout pull/11631
$ git pull https://git.openjdk.org/jdk pull/11631/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11631

View PR using the GUI difftool:
$ git pr show -t 11631

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11631.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2022

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2022
@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@RealFYang The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Dec 12, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2022

Webrevs

Copy link
Contributor

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298568: Fastdebug build fails after JDK-8296389

Reviewed-by: rkennke, kvn, haosun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 829cbc2: 8292674: ReportJNIFatalError should print all java frames
  • be69930: 8288287: Remove expired flags in JDK 21
  • c3bc4fc: 8297505: Declare fields in some sun.security.pkcs11 classes as final
  • c7aca73: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())
  • 781a2e0: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug
  • 9ff85f6: 8298589: java/net/SctpSanity.java fail with NoClassDefFoundError: sun/nio/ch/sctp/UnsupportedUtil
  • 81f57d5: 8298567: Make field in RandomAccessFile final
  • 56c438b: 8297822: De-duplicate code in module jdk.sctp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2022
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial.

Copy link
Contributor

@shqking shqking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I'm not a Reviewer)

@RealFYang
Copy link
Member Author

RealFYang commented Dec 13, 2022

Thank you! Let's
/integrate

@openjdk
Copy link

openjdk bot commented Dec 13, 2022

Going to push as commit 173778e.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 829cbc2: 8292674: ReportJNIFatalError should print all java frames
  • be69930: 8288287: Remove expired flags in JDK 21
  • c3bc4fc: 8297505: Declare fields in some sun.security.pkcs11 classes as final
  • c7aca73: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())
  • 781a2e0: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug
  • 9ff85f6: 8298589: java/net/SctpSanity.java fail with NoClassDefFoundError: sun/nio/ch/sctp/UnsupportedUtil
  • 81f57d5: 8298567: Make field in RandomAccessFile final
  • 56c438b: 8297822: De-duplicate code in module jdk.sctp

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 13, 2022
@openjdk openjdk bot closed this Dec 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@RealFYang Pushed as commit 173778e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants