8298567: Make field in RandomAccessFile final

[minborg]

This PR proposes making a field in RandomAccessFile final. Also, it modernises a switch statement.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298567: Make field in RandomAccessFile final

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer) ⚠️ Review applies to 20c9d49a
• Chris Hegarty (@ChrisHegarty - Reviewer) ⚠️ Review applies to 20c9d49a

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11632/head:pull/11632
$ git checkout pull/11632

Update a local copy of the PR:
$ git checkout pull/11632
$ git pull https://git.openjdk.org/jdk pull/11632/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11632

View PR using the GUI difftool:
$ git pr show -t 11632

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11632.diff

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@minborg The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (99c147a3)
• 01: Full - Incremental (20c9d49a)
• 00: Full (aa682717)

[AlanBateman]

Surprising that RandomAccessFile.fd was not changed to final many years ago. We can do rw at the same time.

[RogerRiggs]

LGTM

[openjdk]

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298567: Make field in RandomAccessFile final

Reviewed-by: rriggs, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 56c438b: 8297822: De-duplicate code in module jdk.sctp
• fabda24: 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors
• 6c23b4f: 8298480: Remove unused KlassRemSet
• 8e5c331: 8298471: Parallel: Don't keep alive nmethods in Young GC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @ChrisHegarty) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[ChrisHegarty]

LGTM

[minborg]

/integrate

[openjdk]

@minborg
Your change (at version 99c147a) is now ready to be sponsored by a Committer.

[RogerRiggs]

/sponsor

[openjdk]

Going to push as commit 81f57d5.
Since your change was applied there have been 4 commits pushed to the master branch:

• 56c438b: 8297822: De-duplicate code in module jdk.sctp
• fabda24: 8296389: C2: PhaseCFG::convert_NeverBranch_to_Goto must handle both orders of successors
• 6c23b4f: 8298480: Remove unused KlassRemSet
• 8e5c331: 8298471: Parallel: Don't keep alive nmethods in Young GC

Your commit was automatically rebased without conflicts.

[openjdk]

@RogerRiggs @minborg Pushed as commit 81f57d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.