8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"

[dfuch]

The test has been observed failing once in the CI, on windows, with a BindException (address already in use) on the client side. This usually means that the system has run out of ephemeral ports or file descriptors. The proposed fix will catch the BindException, run the gc, wait a bit, and retry once. No guarantee that this will actually work - but maybe worth a try, though I worry a bit the authentication count might get wrong if the request that gets the BindException is the first one that follows the 401/407 response - in case the connection was closed after receiving 401/407. Since we have no visibility of which call to connect() fails, it is hard to cater for this possibility without making the test too permissive.

The alternative would be to throw a SkipException in case BindException is received.

While working on the fix I noticed that some parts of the test had been commented out waiting for a RFE to be implemented. Since the RFE has been implemented since then, I went out and uncommented that part of the test.

Comments welcome.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"

Reviewers

• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11634/head:pull/11634
$ git checkout pull/11634

Update a local copy of the PR:
$ git checkout pull/11634
$ git pull https://git.openjdk.org/jdk pull/11634/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11634

View PR using the GUI difftool:
$ git pr show -t 11634

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11634.diff

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0a7b27b0)
• 00: Full (413b3675)

[Michael-Mc-Mahon]

If it only fails rarely, would it be safer to delay a few seconds to allow more time for resources to be freed? Otherwise, the change looks fine to me.

[dfuch]

Good point. What delay would you recommend?

[Michael-Mc-Mahon]

2-3 sec maybe

[Michael-Mc-Mahon]

LGTM

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"

Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• ed8a212: 8298376: ZGC: thaws stackChunk with stale oops
• 2e801e1: 8298475: Remove JVM_ACC_PROMOTED_FLAGS
• 9ee5037: 8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount
• ceca4fc: 8298264: Merge OffsetTableContigSpace into TenuredSpace

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dfuch]

/integrate

[openjdk]

Going to push as commit 0dce5b8.
Since your change was applied there have been 4 commits pushed to the master branch:

• ed8a212: 8298376: ZGC: thaws stackChunk with stale oops
• 2e801e1: 8298475: Remove JVM_ACC_PROMOTED_FLAGS
• 9ee5037: 8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount
• ceca4fc: 8298264: Merge OffsetTableContigSpace into TenuredSpace

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit 0dce5b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.