Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount #11643

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Dec 13, 2022

Simple change of conforming to the return type.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11643/head:pull/11643
$ git checkout pull/11643

Update a local copy of the PR:
$ git checkout pull/11643
$ git pull https://git.openjdk.org/jdk pull/11643/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11643

View PR using the GUI difftool:
$ git pr show -t 11643

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11643.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2022

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8298636 8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount Dec 13, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 13, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial.

Thanks.

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 220781f: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker
  • a120764: 8298514: vmTestbase/nsk/jdi/EventRequestManager/threadDeathRequests/thrdeathreq002/TestDescription.java fails with usage tracker
  • 6802277: 8298524: Debug function to trace reachability of CDS archived heap objects
  • 23e1827: Merge
  • 04b8d0c: 8298084: Memory leak in Method::build_profiling_method_data
  • d453190: 8296955: Kitchensink.java failed with "double free or corruption (!prev): "
  • 8962c72: 8298488: [macos13] tools/jpackage tests failing with "Exit code: 137" on macOS
  • 0267aa5: 8297288: Example code in Scanner class
  • cf93933: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows
  • d624deb: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation
  • ... and 6 more: https://git.openjdk.org/jdk/compare/173778e2fee58e47d35197b78eb23f46154b5b2b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2022
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

Going to push as commit 9ee5037.
Since your change was applied there have been 19 commits pushed to the master branch:

  • ceca4fc: 8298264: Merge OffsetTableContigSpace into TenuredSpace
  • d32d6c0: 8297791: update _max_classes in node type system
  • b754aa5: 8298371: monitors_on_stack extracts unprocessed oops
  • 220781f: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker
  • a120764: 8298514: vmTestbase/nsk/jdi/EventRequestManager/threadDeathRequests/thrdeathreq002/TestDescription.java fails with usage tracker
  • 6802277: 8298524: Debug function to trace reachability of CDS archived heap objects
  • 23e1827: Merge
  • 04b8d0c: 8298084: Memory leak in Method::build_profiling_method_data
  • d453190: 8296955: Kitchensink.java failed with "double free or corruption (!prev): "
  • 8962c72: 8298488: [macos13] tools/jpackage tests failing with "Exit code: 137" on macOS
  • ... and 9 more: https://git.openjdk.org/jdk/compare/173778e2fee58e47d35197b78eb23f46154b5b2b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2022
@openjdk openjdk bot closed this Dec 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@albertnetymk Pushed as commit 9ee5037.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the wb-return-jint branch December 14, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants