8297639: Remove preventive GCs in G1

[tschatzl]

Hi all,

can I have reviews for this removal of preventive gcs for G1?

This feature seems to bring more harm than benefit, so after disabling it by default in JDK 20 (reasons described in JDK-8293861), this change removes the feature altogether.

This is almost a backout of the original change.

Testing: tier1-5

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297639: Remove preventive GCs in G1

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11654/head:pull/11654
$ git checkout pull/11654

Update a local copy of the PR:
$ git checkout pull/11654
$ git pull https://git.openjdk.org/jdk pull/11654/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11654

View PR using the GUI difftool:
$ git pr show -t 11654

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11654.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f66fb6d6)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297639: Remove preventive GCs in G1

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 220781f: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker
• a120764: 8298514: vmTestbase/nsk/jdi/EventRequestManager/threadDeathRequests/thrdeathreq002/TestDescription.java fails with usage tracker
• 6802277: 8298524: Debug function to trace reachability of CDS archived heap objects
• 23e1827: Merge
• 04b8d0c: 8298084: Memory leak in Method::build_profiling_method_data
• d453190: 8296955: Kitchensink.java failed with "double free or corruption (!prev): "
• 8962c72: 8298488: [macos13] tools/jpackage tests failing with "Exit code: 137" on macOS
• 0267aa5: 8297288: Example code in Scanner class
• cf93933: 8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows
• d624deb: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation
• ... and 4 more: https://git.openjdk.org/jdk/compare/dbcfe7bc335846cd154dd78822fb64b7970ff9d2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @albertnetymk @walulyai for your reviews
/integrate

[openjdk]

Going to push as commit 8ff2928.
Since your change was applied there have been 24 commits pushed to the master branch:

• 7241e35: 8298692: Fix typos in test/jdk/com/sun/jdi files
• 736fcd4: 8296318: use-def assert: special case undetected loops nested in infinite loops
• c05dbac: 8193547: Regression automated test '/open/test/jdk/java/awt/Toolkit/DesktopProperties/rfe4758438.java' fails
• 0dce5b8: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
• ed8a212: 8298376: ZGC: thaws stackChunk with stale oops
• 2e801e1: 8298475: Remove JVM_ACC_PROMOTED_FLAGS
• 9ee5037: 8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount
• ceca4fc: 8298264: Merge OffsetTableContigSpace into TenuredSpace
• d32d6c0: 8297791: update _max_classes in node type system
• b754aa5: 8298371: monitors_on_stack extracts unprocessed oops
• ... and 14 more: https://git.openjdk.org/jdk/compare/dbcfe7bc335846cd154dd78822fb64b7970ff9d2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 8ff2928.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.