New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8298709: Fix typos in src/java.desktop/ and various test classes of client component #11661
Conversation
/contributor add mernst |
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
@jaikiran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the stutter elimination.
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you Iris and Phil for the reviews. |
/integrate |
Going to push as commit fa322e4.
Your commit was automatically rebased without conflicts. |
Can I please get a review for this change which only fixes typos? The original PR for this change is #10029. However, that PR included changes to multiple different files in different areas of the JDK and as a result didn't see progress.
This current PR splits off those changes and includes only client area related typo fixes.
Progress
Issue
Reviewers
Contributors
<mernst@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11661/head:pull/11661
$ git checkout pull/11661
Update a local copy of the PR:
$ git checkout pull/11661
$ git pull https://git.openjdk.org/jdk pull/11661/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11661
View PR using the GUI difftool:
$ git pr show -t 11661
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11661.diff