Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298709: Fix typos in src/java.desktop/ and various test classes of client component #11661

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Dec 14, 2022

Can I please get a review for this change which only fixes typos? The original PR for this change is #10029. However, that PR included changes to multiple different files in different areas of the JDK and as a result didn't see progress.

This current PR splits off those changes and includes only client area related typo fixes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298709: Fix typos in src/java.desktop/ and various test classes of client component

Reviewers

Contributors

  • Michael Ernst <mernst@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11661/head:pull/11661
$ git checkout pull/11661

Update a local copy of the PR:
$ git checkout pull/11661
$ git pull https://git.openjdk.org/jdk pull/11661/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11661

View PR using the GUI difftool:
$ git pr show -t 11661

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11661.diff

@jaikiran
Copy link
Member Author

/contributor add mernst

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@jaikiran
Contributor Michael Ernst <mernst@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@jaikiran The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 14, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the stutter elimination.

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298709: Fix typos in src/java.desktop/ and various test classes of client component

Co-authored-by: Michael Ernst <mernst@openjdk.org>
Reviewed-by: iris, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 5412439: 8298187: (fs) BsdFileAttributeViews::setTimes does not support lastAccessTime on HFS+
  • 3cdbd87: 8298241: Replace C-style casts with JavaThread::cast
  • 10737e1: 8298468: Clean up class_loader parameters
  • 4b313b5: 8297798: Timeout with DTLSOverDatagram test template
  • ae8988e: 8297912: HotSpot Style Guide should permit alignas (Second Proposal Attempt)
  • 0ef3539: 8298416: Console should be declared sealed
  • 831b35f: 7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected
  • 0288210: 8298859: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all
  • b17c524: 8298059: Linked stack watermarks don't support nesting
  • 98fa48c: 8298093: improve cleanup and error handling of awt_parseColorModel in awt_parseImage.c
  • ... and 32 more: https://git.openjdk.org/jdk/compare/220781fa56a9c8d3b64c5c6578ffd76b9edb795c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2022
@jaikiran
Copy link
Member Author

Thank you Iris and Phil for the reviews.

@jaikiran
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

Going to push as commit fa322e4.
Since your change was applied there have been 45 commits pushed to the master branch:

  • e41686b: 8298710: Fix typos in test/jdk/sun/security/tools/jarsigner/
  • a336461: 8298081: DiagnoseSyncOnValueBasedClasses doesn't report useful information for virtual threads
  • 2bb727c: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86
  • 5412439: 8298187: (fs) BsdFileAttributeViews::setTimes does not support lastAccessTime on HFS+
  • 3cdbd87: 8298241: Replace C-style casts with JavaThread::cast
  • 10737e1: 8298468: Clean up class_loader parameters
  • 4b313b5: 8297798: Timeout with DTLSOverDatagram test template
  • ae8988e: 8297912: HotSpot Style Guide should permit alignas (Second Proposal Attempt)
  • 0ef3539: 8298416: Console should be declared sealed
  • 831b35f: 7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected
  • ... and 35 more: https://git.openjdk.org/jdk/compare/220781fa56a9c8d3b64c5c6578ffd76b9edb795c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2022
@openjdk openjdk bot closed this Dec 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@jaikiran Pushed as commit fa322e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants