Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds #11665

Closed
wants to merge 1 commit into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Dec 14, 2022

PollingWatchService currently records the last modified time of files in milliseconds. It would be better to just record the FileTime to avoid truncating high precision timestamps to millis.

It's possible this change may also help JDK-8297275.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11665/head:pull/11665
$ git checkout pull/11665

Update a local copy of the PR:
$ git checkout pull/11665
$ git pull https://git.openjdk.org/jdk pull/11665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11665

View PR using the GUI difftool:
$ git pr show -t 11665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11665.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@AlanBateman The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Dec 14, 2022
@AlanBateman AlanBateman changed the title 8298057: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds Dec 14, 2022
@AlanBateman
Copy link
Contributor Author

/issue JDK-8298726

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@AlanBateman This issue is referenced in the PR title - it will now be updated.

@AlanBateman AlanBateman marked this pull request as ready for review December 14, 2022 16:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds

Reviewed-by: bpb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • d1085d1: 8281946: VM.native_memory should report size of shareable memory
  • 3ef3824: 8298794: Remove JVM_ACC_PROMOTED_FLAGS breaks minimal build
  • 0ed6d0b: 8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"
  • a130c8a: Merge
  • 581f9f2: 8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax
  • 0eeaf6b: 8298649: JFR: RemoteRecordingStream support for checkpoint event sizes beyond u4
  • 2791701: 8298296: gc/TestFullGCCount.java fails with "System.gc collections miscounted."
  • 0bbc418: 8294902: Undefined Behavior in C2 regalloc with null references
  • 9bcdfc4: 8298425: System.console().readLine() hangs in jshell
  • 27d4971: 8298520: C2: assert(found_opaque == res) failed: wrong pattern
  • ... and 16 more: https://git.openjdk.org/jdk/compare/220781fa56a9c8d3b64c5c6578ffd76b9edb795c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 14, 2022
@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

Going to push as commit 5f63f7a.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 3ae7187: 8298498: sun/net/www/http/KeepAliveCache/B8291637.java fails with "Server exception terminating: java.net.SocketException: Socket closed"
  • b9074fa: 8298249: Excessive memory allocation in CipherInputStream AEAD decryption
  • 10bc86c: Merge
  • 80cadd4: 8298785: gc/TestFullGCCount.java fails with "invalid boolean value: null' for expression vm.opt.ExplicitGCInvokesConcurrent'"
  • ebc4710: 8298277: Replace "session" with "scope" for FFM access
  • d1085d1: 8281946: VM.native_memory should report size of shareable memory
  • 3ef3824: 8298794: Remove JVM_ACC_PROMOTED_FLAGS breaks minimal build
  • 0ed6d0b: 8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"
  • a130c8a: Merge
  • 581f9f2: 8297235: ZGC: assert(regs[i] != regs[j]) failed: Multiple uses of register: rax
  • ... and 21 more: https://git.openjdk.org/jdk/compare/220781fa56a9c8d3b64c5c6578ffd76b9edb795c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 15, 2022
@openjdk openjdk bot closed this Dec 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 15, 2022
@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@AlanBateman Pushed as commit 5f63f7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
3 participants