-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8249826: 5 javax/net/ssl/SSLEngine tests use @ignore w/o bug-id #11698
Conversation
👋 Welcome back mpdonova! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
@mpdonova This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan, @rhalade, @sisahoo) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@@ -26,8 +26,7 @@ | |||
* @bug 4495742 | |||
* @summary Add non-blocking SSL/TLS functionality, usable with any | |||
* I/O abstraction | |||
* @ignore JSSE supported cipher suites are changed with CR 6916074, | |||
* need to update this test case in JDK 7 soon | |||
* @ignore 8298867 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using ignore tag, I would prefer to put these tests in ProblemList with these bug numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved bugs to ProblemList and removed ignore tags
@mpdonova this pull request can not be integrated into git checkout JDK-8249826
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
/integrate |
/sponsor |
Going to push as commit bf9a8ce.
Your commit was automatically rebased without conflicts. |
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11698/head:pull/11698
$ git checkout pull/11698
Update a local copy of the PR:
$ git checkout pull/11698
$ git pull https://git.openjdk.org/jdk pull/11698/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11698
View PR using the GUI difftool:
$ git pr show -t 11698
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11698.diff