Skip to content

8298921: Create a regression test for JDK-8139581 #11707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

srmandal
Copy link

@srmandal srmandal commented Dec 16, 2022

Create a regression test for JDK-8139581

As described in JDK-8139581, when an AWT panel with AWT components, for example "java.awt.Button", is removed from AWT frame and added again to the same frame, then some AWT components contained in the panel are not drawn, however, clicking in the area of not drawn button leads to drawing of the button.

Test has a swing and awt component in a panel. It then removes and adds back the panel from/into the frame, to verify that they are repainted back properly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298921: Create a regression test for JDK-8139581

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11707/head:pull/11707
$ git checkout pull/11707

Update a local copy of the PR:
$ git checkout pull/11707
$ git pull https://git.openjdk.org/jdk pull/11707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11707

View PR using the GUI difftool:
$ git pr show -t 11707

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11707.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2022

👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@srmandal
Copy link
Author

This review is for migrating tests from a closed test suite to open.
Testing:
The test ran successfully on Mach5 with multiple runs (40) on windows-x64, linux-x64 and macos-x64.

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@srmandal The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 16, 2022
@srmandal srmandal marked this pull request as ready for review December 19, 2022 08:31
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2022

Webrevs

@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 5, 2023
@srmandal srmandal requested a review from mrserb January 5, 2023 09:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2023
@openjdk
Copy link

openjdk bot commented Jan 6, 2023

@srmandal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298921: Create a regression test for JDK-8139581

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 167 new commits pushed to the master branch:

  • 7845b0d: 8296934: Write a test to verify whether Undecorated Frame can be iconified or not
  • 4b6809b: 8299693: Change to Xcode12.4+1.1 devkit for building on macOS at Oracle
  • dfdbd0f: 8299343: Windows: Invalid thread_native_entry declaration
  • 3e2314d: 8299254: Support dealing with standard assert macro
  • a49ccb9: 8299292: Missing elements in aliased String array
  • b908388: 8298449: Unnecessary Vector usage in MetaData.ProxyPersistenceDelegate
  • be64bf8: 8299329: Assertion failure with fastdebug build when trying to use CDS without classpath
  • 8723847: 8298848: C2: clone all of (CmpP (LoadKlass (AddP down at split if
  • 1ca31d3: 8299657: sun/tools/jhsdb/SAGetoptTest.java fails after 8299470
  • e7361cb: 8299430: Cleanup: delete unnecessary semicolons in java.desktop module
  • ... and 157 more: https://git.openjdk.org/jdk/compare/226e579c3004a37a09f3329a8ef09c0933126bd6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2023
@srmandal
Copy link
Author

srmandal commented Jan 6, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 6, 2023
@openjdk
Copy link

openjdk bot commented Jan 6, 2023

@srmandal
Your change (at version 4d55e82) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Jan 8, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 8, 2023

Going to push as commit 834e50e.
Since your change was applied there have been 193 commits pushed to the master branch:

  • e209693: 8258776: ThreadLocal#initialValue() Javadoc is unaware of ThreadLocal#withInitial()
  • d5b80ab: 8299617: CurrencySymbols.properties is missing the copyright notice
  • 63cf4aa: 8299499: Usage of constructors of primitive wrapper classes should be avoided in java.net API docs
  • 5393dc9: Merge
  • 1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
  • 5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
  • 136f5db: 8299528: IR test: TestEor3AArch64.java fails on aarch64
  • 284c94e: 8298525: javadoc crashes with "UnsupportedOperationException: Not yet implemented" in SeeTaglet.inherit
  • 9c4ed16: 8299561: VaList.empty() doesn't return a list associated with the global scope
  • 7310131: 8299337: The java.awt.image.ColorModel#pData field is unused
  • ... and 183 more: https://git.openjdk.org/jdk/compare/226e579c3004a37a09f3329a8ef09c0933126bd6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 8, 2023
@openjdk openjdk bot closed this Jan 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 8, 2023
@openjdk
Copy link

openjdk bot commented Jan 8, 2023

@mrserb @srmandal Pushed as commit 834e50e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@srmandal srmandal deleted the 8298921 branch February 19, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants