-
Notifications
You must be signed in to change notification settings - Fork 5.8k
JDK-8299022: Linux ppc64le and s390x build issues after JDK-8160404 #11719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing!
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified on s390x.
Thanks for fixing.
Hi Lutz and Martin, thanks for the reviews ! /integrate |
Going to push as commit 756a06d.
Your commit was automatically rebased without conflicts. |
Looks like JDK-8160404 caused issues in the Linux ppc64le build.
We now run into
/openjdk/nb/linuxppc64le/jdk/src/hotspot/cpu/ppc/assembler_ppc.hpp:98:49: error: no matching function for call to 'RelocationHolder::RelocationHolder(NULL)'
AddressLiteral() : _address(NULL), _rspec(NULL) {}
This change changes the usage of a constructor that is no longer present after JDK-8160404 .
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11719/head:pull/11719
$ git checkout pull/11719
Update a local copy of the PR:
$ git checkout pull/11719
$ git pull https://git.openjdk.org/jdk pull/11719/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11719
View PR using the GUI difftool:
$ git pr show -t 11719
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11719.diff