Skip to content

JDK-8299022: Linux ppc64le and s390x build issues after JDK-8160404 #11719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 19, 2022

Looks like JDK-8160404 caused issues in the Linux ppc64le build.
We now run into

/openjdk/nb/linuxppc64le/jdk/src/hotspot/cpu/ppc/assembler_ppc.hpp:98:49: error: no matching function for call to 'RelocationHolder::RelocationHolder(NULL)'
AddressLiteral() : _address(NULL), _rspec(NULL) {}

This change changes the usage of a constructor that is no longer present after JDK-8160404 .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299022: Linux ppc64le and s390x build issues after JDK-8160404

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11719/head:pull/11719
$ git checkout pull/11719

Update a local copy of the PR:
$ git checkout pull/11719
$ git pull https://git.openjdk.org/jdk pull/11719/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11719

View PR using the GUI difftool:
$ git pr show -t 11719

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11719.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 19, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2022

Webrevs

@MBaesken MBaesken changed the title JDK-8299022: Linux ppc64le build issues after JDK-8160404 JDK-8299022: Linux ppc64le and s390x build issues after JDK-8160404 Dec 19, 2022
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing!

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299022: Linux ppc64le and s390x build issues after JDK-8160404

Reviewed-by: mdoerr, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • de0ce79: 8297801: printnm crashes with invalid address due to null pointer dereference
  • da38d43: 8296412: Special case infinite loops with unmerged backedges in IdealLoopTree::check_safepts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 19, 2022
Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified on s390x.
Thanks for fixing.

@MBaesken
Copy link
Member Author

Hi Lutz and Martin, thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

Going to push as commit 756a06d.
Since your change was applied there have been 2 commits pushed to the master branch:

  • de0ce79: 8297801: printnm crashes with invalid address due to null pointer dereference
  • da38d43: 8296412: Special case infinite loops with unmerged backedges in IdealLoopTree::check_safepts

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2022
@openjdk openjdk bot closed this Dec 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@MBaesken Pushed as commit 756a06d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants