Skip to content

8298931: java/net/httpclient/CancelStreamedBodyTest.java fails with AssertionError due to Pending TCP connections: 1 #11725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented Dec 19, 2022

The CancelStreamedBodyTest.java and ISO_8859_1_Test.java were observed failing in AssertioError due to resources not being released in the imparted time. I am suspecting this to occur on particularly slow/overloaded machines.

This change propose to increase the time these two tests wait for resources to be released. It also improves traces in the ReferenceTracker to give better visibility on the tracker waiting loop and help better diagnose any future issue that might be cause by the tracker not waiting long enough.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298931: java/net/httpclient/CancelStreamedBodyTest.java fails with AssertionError due to Pending TCP connections: 1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11725/head:pull/11725
$ git checkout pull/11725

Update a local copy of the PR:
$ git checkout pull/11725
$ git pull https://git.openjdk.org/jdk pull/11725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11725

View PR using the GUI difftool:
$ git pr show -t 11725

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11725.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2022

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8298931 8298931: java/net/httpclient/CancelStreamedBodyTest.java fails with AssertionError due to Pending TCP connections: 1 Dec 19, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Dec 19, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2022

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298931: java/net/httpclient/CancelStreamedBodyTest.java fails with AssertionError due to Pending TCP connections: 1

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 36de61c: 8298865: Excessive memory allocation in CipherOutputStream AEAD decryption
  • dd15d30: 8299043: test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java fails with java.lang.NullPointerException
  • 05f9e76: 8298974: Add ftcolor.c to imported freetype sources
  • abc1297: 8299044: test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac
  • 5d330f5: 8299045: tools/doclint/BadPackageCommentTest.java fails after JDK-8298943
  • 40cb431: 8298943: Missing escapes for single quote marks in compiler.properties
  • 9194e91: 8298701: Cleanup SA entries in ProblemList-zgc.txt.
  • 4c927df: 8298470: Short cut java.lang.Object super class loading
  • 756a06d: 8299022: Linux ppc64le and s390x build issues after JDK-8160404
  • de0ce79: 8297801: printnm crashes with invalid address due to null pointer dereference
  • ... and 1 more: https://git.openjdk.org/jdk/compare/8e49fcdde4fef5a8db36823b35d409ba2c9ec47b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2022
@dfuch
Copy link
Member Author

dfuch commented Dec 20, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

Going to push as commit 5df00d3.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 36de61c: 8298865: Excessive memory allocation in CipherOutputStream AEAD decryption
  • dd15d30: 8299043: test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java fails with java.lang.NullPointerException
  • 05f9e76: 8298974: Add ftcolor.c to imported freetype sources
  • abc1297: 8299044: test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac
  • 5d330f5: 8299045: tools/doclint/BadPackageCommentTest.java fails after JDK-8298943
  • 40cb431: 8298943: Missing escapes for single quote marks in compiler.properties
  • 9194e91: 8298701: Cleanup SA entries in ProblemList-zgc.txt.
  • 4c927df: 8298470: Short cut java.lang.Object super class loading
  • 756a06d: 8299022: Linux ppc64le and s390x build issues after JDK-8160404
  • de0ce79: 8297801: printnm crashes with invalid address due to null pointer dereference
  • ... and 1 more: https://git.openjdk.org/jdk/compare/8e49fcdde4fef5a8db36823b35d409ba2c9ec47b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 20, 2022
@openjdk openjdk bot closed this Dec 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@dfuch Pushed as commit 5df00d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants