Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero" #11726

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Dec 19, 2022

Please review this limited fix to make symbol refcount not go to zero for the placeholder supername field. This supername field is to detect ClassCircularityError for parallel capable class loaders without deadlocking.
ie. t1 : Class A (lock object for A) -> super B (wait for lock object for B)
t2: Class B (lock object for B) -> super A (wait for lock object for A).

We get the supername field out of the placeholder table to do the check for super class CCE but the reference count in the placeholder table for this name can be one. The fix is not to decrement and increment if the name is the same.

Tested with tier1-4.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298061: vmTestbase/nsk/sysdict/vm/stress/btree/btree012/btree012.java failed with "fatal error: refcount has gone to zero"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11726/head:pull/11726
$ git checkout pull/11726

Update a local copy of the PR:
$ git checkout pull/11726
$ git pull https://git.openjdk.org/jdk pull/11726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11726

View PR using the GUI difftool:
$ git pr show -t 11726

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11726.diff

…a failed with "fatal error: refcount has gone to zero"
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2022

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 19, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2022

Webrevs

@coleenp
Copy link
Contributor Author

coleenp commented Dec 19, 2022

This was supposed to be relative to the JDK 20 repository.

@coleenp coleenp closed this Dec 19, 2022
@coleenp coleenp deleted the symbol branch December 19, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review
1 participant