8299043 : test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java fails with java.lang.NullPointerException

[lawrence-andrew]

Test was failing with java.lang.NullPointerException due to image file extension was specified in upper case ( GIF ) https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java#L44-L50 but actually it is in smaller case ( gif ) https://github.com/openjdk/jdk/tree/master/test/jdk/javax/swing/AbstractButton/5049549 .
The was working as expected in mac but failed in ubuntu. After fixing the image file extension( gif ) and run the test it worked and exception was not reproduced.

@shurymury
@honkar-jdk

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299043: test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java fails with java.lang.NullPointerException

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11731/head:pull/11731
$ git checkout pull/11731

Update a local copy of the PR:
$ git checkout pull/11731
$ git pull https://git.openjdk.org/jdk pull/11731/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11731

View PR using the GUI difftool:
$ git pr show -t 11731

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11731.diff

[bridgekeeper]

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lawrence-andrew The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299043: test/jdk/javax/swing/AbstractButton/5049549/bug5049549.java fails with java.lang.NullPointerException

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 5d330f5: 8299045: tools/doclint/BadPackageCommentTest.java fails after JDK-8298943

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (2c81216c)

[lawrence-andrew]

/integrate

[openjdk]

@lawrence-andrew
Your change (at version 2c81216) is now ready to be sponsored by a Committer.

[mrserb]

/sponsor

[openjdk]

Going to push as commit dd15d30.
Since your change was applied there have been 3 commits pushed to the master branch:

• 05f9e76: 8298974: Add ftcolor.c to imported freetype sources
• abc1297: 8299044: test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac
• 5d330f5: 8299045: tools/doclint/BadPackageCommentTest.java fails after JDK-8298943

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb @lawrence-andrew Pushed as commit dd15d30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.