8298887: On the latest macOS+XCode the Robot API may report wrong colors

[mrserb]

The new macOS SDK provided by XCode 14.2 changed this macro:
# define kCGBitmapByteOrder32Host kCGBitmapByteOrder32Little
to this constant
static const CGBitmapInfo kCGBitmapByteOrder32Host = kCGBitmapByteOrder32Little;

As a result, our native code started to redefine the macro value to "define kCGBitmapByteOrder32Host 0". I think that was added a long time ago for a PPC platform.

I have also changed the type of the color we pass to the java Robot, the java code expects the xrgb format(the alpha ignored), but we for some reason prepared pre-multiplied alpha.

Tested on macOS 12.6.1 and 13.0.1 using xcode 14.2 and xcode 12.5.1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298887: On the latest macOS+XCode the Robot API may report wrong colors

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11733/head:pull/11733
$ git checkout pull/11733

Update a local copy of the PR:
$ git checkout pull/11733
$ git pull https://git.openjdk.org/jdk pull/11733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11733

View PR using the GUI difftool:
$ git pr show -t 11733

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11733.diff

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5a1de223)

[azvegint]

Looks good.
Testing on macosx-aarch64 and macosx-x64 also looks good.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298887: On the latest macOS+XCode the Robot API may report wrong colors

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 88bfe4d: 8297724: Loop strip mining prevents some empty loops from being eliminated
• a7d6de7: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes
• b005013: 8296275: Write a test to verify setAccelerator method of JMenuItem
• 85f9b37: 8297682: Use Collections.emptyIterator where applicable
• f36e144: 8299025: BMPImageReader.java readColorPalette could use staggeredReadByteStream
• f56285c: 8299146: No copyright statement on ArtifactResolverException.java
• 396a9bf: 8298913: Add override qualifiers to Relocation classes
• 386db07: Merge
• f4d7f43: 8299123: [BACKOUT] 4512626 Non-editable JTextArea provides no visual indication of keyboard focus
• 03afec1: 8298162: Test PrintClasses hits assert when run with code that retransform classes
• ... and 27 more: https://git.openjdk.org/jdk/compare/5d330f5285b535b37dde5cd4e42374d92fafb550...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

Going to push as commit 5012039.
Since your change was applied there have been 49 commits pushed to the master branch:

• 34cdda5: Merge
• 22007a1: 8298893: Rename option UsePolyIntrinsics to UsePoly1305Intrinsics
• 9adc349: 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds
• 81933b7: 8298642: ParallelGC -XX:+UseNUMA eden spaces allocated on wrong node
• 92fe304: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body
• f7be5b5: 8299156: Broken link in jdk.compiler/module-info.java
• 3d4d9fd: 8298947: compiler/codecache/MHIntrinsicAllocFailureTest.java fails intermittently
• e85d00f: 8299147: Minor accessibility errors in the specs and man index pages
• f80face: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails
• 7e59a0e: 8298971: Move Console implementation into jdk internal package
• ... and 39 more: https://git.openjdk.org/jdk/compare/5d330f5285b535b37dde5cd4e42374d92fafb550...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 5012039.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.