-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8299260: libawt and libfreetype should export only explicitly requested symbols #11742
Conversation
👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into |
@djelinski The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Hmm, not easy to know for sure what might be affected. But it's early in JDK 21, so ... |
yes, I did build After these changes, all of the bundled exports were present in system library. The following exports of the system library were absent in the bundled one:
These exports were absent even before my changes, so I believe we should be fine here. |
I can't speak to all of these but we only have a subset of freetype in JDK sources, since for example we have no interest in the bitmap formats, so some of the differences are no surprise. I don't have anything definite to say will be broken by this, so I'll approve this so we can get it in to the builds and we'll see if it causes problems. |
@djelinski This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 52 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Then I suggest filing a new bug to track additional issues raised in JDK-8200192 and editing the description and the subject of JDK-8200192 correspondingly to reflect the current fix only. |
Thanks for the suggestion! I'll create a new bug for this fix instead, and leave a comment on the existing one. |
Thank you! This way it's clearer. What about libfreetype? You also modify its settings. libawt and libfreetype should export only explicitly requested symbols Does this subject look good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of exported symbols from libawt
and libfreetype
is much lower now: 192 vs 970 and 222 vs 560.
I ran clientlibs tests, no failures detected.
/integrate |
Going to push as commit 684e506.
Your commit was automatically rebased without conflicts. |
@djelinski Pushed as commit 684e506. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this patch that removes unnecessary exports from libawt and libfreetype.
Verified that:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11742/head:pull/11742
$ git checkout pull/11742
Update a local copy of the PR:
$ git checkout pull/11742
$ git pull https://git.openjdk.org/jdk pull/11742/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11742
View PR using the GUI difftool:
$ git pr show -t 11742
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11742.diff