Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 #11747

Closed
wants to merge 4 commits into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Dec 20, 2022

ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added robot.setAutoWaitForIdle() to ViewportOverlapping and its base class (OverlappingTestBase) to stabilize the test.

Additionally added awt & swings tests to exclusiveAccess.dir in TEST.ROOT.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/11747/head:pull/11747
$ git checkout pull/11747

Update a local copy of the PR:
$ git checkout pull/11747
$ git pull https://git.openjdk.org/jdk.git pull/11747/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11747

View PR using the GUI difftool:
$ git pr show -t 11747

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11747.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@honkar-jdk The following labels will be automatically applied to this pull request:

  • client
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Dec 20, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2022

Webrevs

@honkar-jdk honkar-jdk changed the title JDK-8299052: ViewportOverlapping test fails on Win10 & Win11 JDK-8299052: ViewportOverlapping test fails intermittently on Win10 & Win11 Dec 20, 2022
com/sun/net/httpserver/simpleserver
com/sun/net/httpserver/simpleserver \
java/awt \
javax/swing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Harshitha, I don't have any knowledge of the client area, but I see that there are a large number of tests that are present in test/jdk/java/awt and test/jdk/javax/swing. Adding these 2 directories to exclusiveAccess.dirs would mean that none of the tests in java/awt will be run when any other test in java/awt is currently in progress. Same with the javax/swing directory. So it could increase the duration of the tiers in which these tests run. Is there a CI run which shows if this changes the test run duration drastically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaikiran Thank you for the details. I'll check if the duration of run differed drastically. I thought all the client tests run in non-concurrent mode by default or does this differ for headful and headless test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headful tests are not supposed concurrently: they display UI and often use Robot to send input events to the UI. Running such tests concurrently leads to obscure failures. In our CI system, JTREG_JOBS=1 is passed to make when running headful tests.

There's a set of headless tests which can be run concurrently. Such tests will be affected if they're run concurrently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aivanov-jdk If it affects the run time of certain group of tests then it is better not to add it to exclusiveAccess.dirs and explicitly specify the JTREG_JOBS=1 instead as both produce same results?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, headless suite is affected. Therefore neither java/awt nor javax/swing should be added to exclusiveAccess.dirs.

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also expand imports in OverlappingTestBase.java?

Comment on lines 460 to 464
try {
robot = new Robot();
robot.setAutoWaitForIdle(true);
}catch(Exception ignorex) {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to extract this code into a new method?

@mrserb
Copy link
Member

mrserb commented Dec 22, 2022

What was the reason for failure? Something was too fast or too slow?

@AlanBateman
Copy link
Contributor

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@AlanBateman
The core-libs label was successfully removed.

@jayathirthrao
Copy link
Member

Are these tests verified in our CI with multiple runs after exclusiveAccess is removed?

@aivanov-jdk
Copy link
Member

Are these tests verified in our CI with multiple runs after exclusiveAccess is removed?

These tests have always run in exclusive access in the CI.

@honkar-jdk honkar-jdk marked this pull request as draft January 27, 2023 01:51
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 27, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2023

@honkar-jdk This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 11, 2023

@honkar-jdk This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org
6 participants