Skip to content

8299261: Clean up AWT D3D exports #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Dec 22, 2022

Please review this patch that removes unnecessary exports from awt.dll.

The exports were introduced in e4c9db9, and as far as I could tell, they were never used; the exported functions are only used inside awt.dll.

Verified that:

  • debug and release builds finish successfully
  • mach5 client libs tests pass

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11765/head:pull/11765
$ git checkout pull/11765

Update a local copy of the PR:
$ git checkout pull/11765
$ git pull https://git.openjdk.org/jdk pull/11765/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11765

View PR using the GUI difftool:
$ git pr show -t 11765

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11765.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2022

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8299261 8299261: Clean up AWT D3D exports Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@djelinski The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 22, 2022
@djelinski djelinski marked this pull request as ready for review December 22, 2022 10:11
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 22, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299261: Clean up AWT D3D exports

Reviewed-by: serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 129 new commits pushed to the master branch:

  • 679e485: 8043251: Bogus javac error: required: no arguments, found: no arguments
  • cd10c72: 8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs
  • bfd5971: 8299757: Update JCov version to 3.0.14
  • 17a3f0e: 8299275: Add some ClassLoaderData verification code
  • 4ba8122: 8299312: Clean up BarrierSetNMethod
  • 66db0bb: 8299692: G1: Remove unused G1BlockOffsetTable::is_card_boundary
  • 7068457: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options
  • 500c3c1: 8298730: Refactor subsystem_file_line_contents and add docs and tests
  • 4072412: 8298876: Swing applications do not get repainted coming out of sleep on Windows 10
  • a503ec2: 8299608: Add Register + imm32 orq to x86_64 assembler
  • ... and 119 more: https://git.openjdk.org/jdk/compare/50120396b6cca1219fb5dd42a11e4b29b79bd3bd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 22, 2022
@djelinski
Copy link
Member Author

Happy new year!
Thanks @mrserb for your review. Can I get a second opinion on this?

The patch removes 139 functions from the list of exports, and reduces the binary size by a few kilobytes.
The GHA failure is unrelated.

@djelinski
Copy link
Member Author

Thanks for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

Going to push as commit f95346e.
Since your change was applied there have been 138 commits pushed to the master branch:

  • 195f313: 8287925: AArch64: intrinsics for compareUnsigned method in Integer and Long
  • 3a66737: 8299525: RISC-V: Add backend support for half float conversion intrinsics
  • b7eb4e2: 8297306: Incorrect brackets in Javadoc for a constructor of IteratorSpliterator
  • a638663: 8255119: Monitor::wait takes signed integer as timeout
  • 4395578: Merge
  • d49851a: 8299689: Make use of JLine for Console as "opt-in"
  • f79b3d4: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
  • f36f135: 8299501: Usage of constructors of primitive wrapper classes should be avoided in java.util API docs
  • b8852f6: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs
  • 679e485: 8043251: Bogus javac error: required: no arguments, found: no arguments
  • ... and 128 more: https://git.openjdk.org/jdk/compare/50120396b6cca1219fb5dd42a11e4b29b79bd3bd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2023
@openjdk openjdk bot closed this Jan 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@djelinski Pushed as commit f95346e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the awt-d3d-export-cleanup branch January 10, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants