Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8235297: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java fails intermittent #11766

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 22, 2022

The test sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java fails intermittent with timeouts , this info should be added to the test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8235297: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java fails intermittent

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11766/head:pull/11766
$ git checkout pull/11766

Update a local copy of the PR:
$ git checkout pull/11766
$ git pull https://git.openjdk.org/jdk pull/11766/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11766

View PR using the GUI difftool:
$ git pr show -t 11766

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11766.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@MBaesken The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 22, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2022

Webrevs

Copy link
Member

@XueleiFan XueleiFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I guess the intermittent failure issue could be addressed by using the new template, but it may be not worthy of the effort.

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8235297: sun/security/ssl/SSLSessionImpl/ResumptionUpdateBoundValues.java fails intermittent

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 62a033e: 8299191: Unnecessarily global friend functions for relocInfo
  • a3693cc: 8295087: Manual Test to Automated Test Conversion

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 22, 2022
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 28, 2022

Going to push as commit d490f15.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 11fd651: 8298875: A module requiring "java.base" with flags ACC_SYNTHETIC should be rejected
  • 0459159: 8288204: GVN Crash: assert() failed: correct memory chain
  • 19373b2: Merge
  • 188911c: 8299241: jdk/jfr/api/consumer/streaming/TestJVMCrash.java generates unnecessary core file
  • 26868c1: 8299255: Unexpected round errors in FreetypeFontScaler
  • 5e861e3: 8298645: JNI works with accessibleSelection on a wrong thread
  • fd746a2: 8298643: JNI call of getAccessibleRowWithIndex and getAccessibleColumnWithIndex on a wrong thread
  • da75de3: 8299172: RISC-V: [TESTBUG] Fix stack alignment logic in jvmci RISCV64TestAssembler.java
  • 19ce23c: Merge
  • 33042a4: 8299237: add ArraysSupport.newLength test to a test group
  • ... and 12 more: https://git.openjdk.org/jdk/compare/50120396b6cca1219fb5dd42a11e4b29b79bd3bd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 28, 2022
@openjdk openjdk bot closed this Dec 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 28, 2022
@openjdk
Copy link

openjdk bot commented Dec 28, 2022

@MBaesken Pushed as commit d490f15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants