8299227: host exif.org not found in link in doc comment
#11768
Conversation
|
👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into |
|
@kumarabhi006 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
Since this is a simple change we can still push it to JDK20. |
|
The suggestion was to fix this doc bug in JDK20. So this is the wrong repo. |
| @@ -78,7 +78,7 @@ | |||
| * <tr> | |||
| * <td>Exif JPEG</td> | |||
| * <td>Exif-specific JPEG compression (see note following this table)</td> | |||
| * <td><a href="http://www.exif.org/Exif2-2.PDF">Exif 2.2 Specification</a> | |||
| * <td><a href="https://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf">Exif 2.2 Specification</a> | |||
There was a problem hiding this comment.
BTW the link at the other end is EXIF 2.3 .. so you probably want to fix the text too.
| @@ -78,7 +78,7 @@ | |||
| * <tr> | |||
| * <td>Exif JPEG</td> | |||
| * <td>Exif-specific JPEG compression (see note following this table)</td> | |||
| * <td><a href="http://www.exif.org/Exif2-2.PDF">Exif 2.2 Specification</a> | |||
| * <td><a href="https://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf">Exif 2.2 Specification</a> | |||
| * (PDF), section 4.5.5, "Basic Structure of Thumbnail Data"</td> | |||
| @@ -574,7 +574,8 @@ <h3><a id="Compression">Compression</a></h3> | |||
| <th scope="row">9</th> | |||
| <td>Exif JPEG</td> | |||
| <td>Exif-specific JPEG compression (see note following this table)</td> | |||
| <td><a href="http://www.exif.org/Exif2-2.PDF">Exif 2.2 Specification</a> | |||
| <td><a href="https://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf"> | |||
| Exif 2.2 Specification</a> | |||
| (PDF), section 4.5.5, "Basic Structure of Thumbnail Data"</td> | |||
| @@ -1614,7 +1614,7 @@ Java_com_sun_imageio_plugins_jpeg_JPEGImageReader_setSource | |||
| /* | |||
| * For EXIF images, the APP1 will appear immediately after the SOI, | |||
| * so it's safe to only look at the first marker in the list. | |||
| * (see http://www.exif.org/Exif2-2.PDF, section 4.7, page 58) | |||
| * (see https://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf, section 4.7, page 58) | |||
| */ | |||
| #define IS_EXIF(c) \ | |||
There was a problem hiding this comment.
Page number is no longer correct
There was a problem hiding this comment.
I think it should be page 83
| @@ -1715,7 +1715,7 @@ Java_com_sun_imageio_plugins_jpeg_JPEGImageReader_readImageHeader | |||
| * - we got JFIF image | |||
| * Must be YCbCr (see http://www.w3.org/Graphics/JPEG/jfif3.pdf, page 2) | |||
| * - we got EXIF image | |||
| * Must be YCbCr (see http://www.exif.org/Exif2-2.PDF, section 4.7, page 63) | |||
| * Must be YCbCr (see https://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf, section 4.7, page 63) | |||
There was a problem hiding this comment.
Page number is no longer correct - think p88 now
|
I will raise a PR for JDK20 repo with suggested changes. |
|
Withdrawing this PR. |
Broken links are replaced by the similar links fixed in JDK-8288527 for file
src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java.Progress
Issue
exif.orgnot found in link in doc commentReviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11768/head:pull/11768$ git checkout pull/11768Update a local copy of the PR:
$ git checkout pull/11768$ git pull https://git.openjdk.org/jdk pull/11768/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11768View PR using the GUI difftool:
$ git pr show -t 11768Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11768.diff