Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299237: add ArraysSupport.newLength test to a test group #11769

Conversation

stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Dec 22, 2022

This test isn't part of any test group, so it isn't being run regularly! I'm adding it to the jdk_util_other test group.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299237: add ArraysSupport.newLength test to a test group

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11769/head:pull/11769
$ git checkout pull/11769

Update a local copy of the PR:
$ git checkout pull/11769
$ git pull https://git.openjdk.org/jdk pull/11769/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11769

View PR using the GUI difftool:
$ git pr show -t 11769

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11769.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2022

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 22, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2022

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Test fixes are ok for JDK 20 backport.

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299237: add ArraysSupport.newLength test to a test group

Reviewed-by: naoto, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b378381: 8299199: Avoid redundant split calls in FontConfiguration.initReorderMap implementations
  • 62a033e: 8299191: Unnecessarily global friend functions for relocInfo
  • a3693cc: 8295087: Manual Test to Automated Test Conversion
  • 5012039: 8298887: On the latest macOS+XCode the Robot API may report wrong colors

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 22, 2022
@stuart-marks
Copy link
Member Author

@RogerRiggs

LGTM; Test fixes are ok for JDK 20 backport.

Thanks. Do you think I should push this into JDK 20 instead of 21?

@RogerRiggs
Copy link
Contributor

Thanks. Do you think I should push this into JDK 20 instead of 21?

Yes, if the test should be run (and has not been running) pushing to 20 will get it running sooner on the release that ships next.

@stuart-marks
Copy link
Member Author

OK, I guess I'll need to withdraw this PR and open a new one against JDK 20.

@RogerRiggs
Copy link
Contributor

Or you can push to 21 and then use the lightweight "/backport" command.

@naotoj
Copy link
Member

naotoj commented Dec 22, 2022

I think backporting should do in this case (and simpler)

@stuart-marks
Copy link
Member Author

Yeah it would probably be simpler but it would clutter up the history. I've already started cloning jdk20 anyway, no big deal.

@stuart-marks
Copy link
Member Author

Closing this in favor of PR openjdk/jdk20#73 on JDK 20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
3 participants