Skip to content

8299296: Write a test to verify the components selection sends ItemEvent#11786

Closed
ravigupta30 wants to merge 2 commits intoopenjdk:masterfrom
ravigupta30:8299296
Closed

8299296: Write a test to verify the components selection sends ItemEvent#11786
ravigupta30 wants to merge 2 commits intoopenjdk:masterfrom
ravigupta30:8299296

Conversation

@ravigupta30
Copy link
Contributor

@ravigupta30 ravigupta30 commented Dec 24, 2022

This testcase verifies the following assertions

a. Selecting an item in the Choice using mouse generates ItemEvent.
b. Single-click on an Checkbox generates ItemEvent.

Testing:
Tested using Mach5(20 times per platform) in macos, linux and windows and got all pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299296: Write a test to verify the components selection sends ItemEvent

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11786/head:pull/11786
$ git checkout pull/11786

Update a local copy of the PR:
$ git checkout pull/11786
$ git pull https://git.openjdk.org/jdk pull/11786/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11786

View PR using the GUI difftool:
$ git pr show -t 11786

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11786.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2022

👋 Welcome back ravigupta30! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 24, 2022

@ravigupta30 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 24, 2022
@ravigupta30 ravigupta30 changed the title Write a test to verify the components selection sends ItemEvent 8299296: Write a test to verify the components selection sends ItemEvent Dec 24, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 24, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 24, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

⚠️ @ravigupta30 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8299296
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@ravigupta30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299296: Write a test to verify the components selection sends ItemEvent

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2023
@ravigupta30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@ravigupta30
Your change (at version e02b3d2) is now ready to be sponsored by a Committer.

@ravigupta30
Copy link
Contributor Author

Any volunteers for a sponsor?

@ravigupta30
Copy link
Contributor Author

@mrserb requesting you to please sponsor.

@mrserb
Copy link
Member

mrserb commented Jan 4, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 4, 2023

Going to push as commit 5ae6de8.
Since your change was applied there have been 64 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2023
@openjdk openjdk bot closed this Jan 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 4, 2023
@openjdk
Copy link

openjdk bot commented Jan 4, 2023

@mrserb @ravigupta30 Pushed as commit 5ae6de8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants