8299296: Write a test to verify the components selection sends ItemEvent#11786
8299296: Write a test to verify the components selection sends ItemEvent#11786ravigupta30 wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ravigupta30! A progress list of the required criteria for merging this PR into |
|
@ravigupta30 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
test/jdk/java/awt/event/ComponentEvent/ComponentItemEventTest.java
Outdated
Show resolved
Hide resolved
|
|
@ravigupta30 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@ravigupta30 |
|
Any volunteers for a sponsor? |
|
@mrserb requesting you to please sponsor. |
|
/sponsor |
|
Going to push as commit 5ae6de8.
Your commit was automatically rebased without conflicts. |
|
@mrserb @ravigupta30 Pushed as commit 5ae6de8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This testcase verifies the following assertions
a. Selecting an item in the Choice using mouse generates ItemEvent.
b. Single-click on an Checkbox generates ItemEvent.
Testing:
Tested using Mach5(20 times per platform) in macos, linux and windows and got all pass.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11786/head:pull/11786$ git checkout pull/11786Update a local copy of the PR:
$ git checkout pull/11786$ git pull https://git.openjdk.org/jdk pull/11786/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11786View PR using the GUI difftool:
$ git pr show -t 11786Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11786.diff