8299378: sprintf is deprecated in Xcode 14 by XueleiFan · Pull Request #11793 · openjdk/jdk

XueleiFan · 2022-12-28T05:52:27Z

The sprintf is deprecated in Xcode 14 because of security concerns. The issue was addressed in JDK-8296812, but the test was not covered. The failure was reported later, while gtest is enabled for building.

This patch is just to make sure the building could pass. Other than that, the use of sprintf in other places are not touched.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8299378: sprintf is deprecated in Xcode 14

Reviewers

Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to 3d5f9d43
David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 3d5f9d43

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11793/head:pull/11793
$ git checkout pull/11793

Update a local copy of the PR:
$ git checkout pull/11793
$ git pull https://git.openjdk.org/jdk pull/11793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11793

View PR using the GUI difftool:
$ git pr show -t 11793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11793.diff

bridgekeeper · 2022-12-28T05:54:04Z

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-12-28T05:57:11Z

@XueleiFan The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-12-28T06:00:28Z

Webrevs

kimbarrett

Looks good.

openjdk · 2023-01-02T00:12:37Z

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299378: sprintf is deprecated in Xcode 14

Reviewed-by: kbarrett, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

ea25a56: 8299520: TestPrintXML.java output error messages in case compare fails
92dfc73: 8294526: sun/security/provider/SubjectCodeSource.java no longer referenced
3d0db02: Merge
a6a903d: 8288204: GVN Crash: assert() failed: correct memory chain
37f8b05: 8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics
245f0cf: 8291302: ARM32: nmethod entry barriers support
a9ce772: 8299437: Make InetSocketAddressHolder shallowly immutable
8afd665: 8299395: Remove metaprogramming/removeCV.hpp
3757433: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
417d01e: 8299441: Fix typos in some test files under core-libs component
... and 18 more: https://git.openjdk.org/jdk/compare/11fd651ab1820770e3c65cd49589416098987a87...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

dholmes-ora

Seems fine. Thanks. One nit below.

test/hotspot/gtest/utilities/test_unsigned5.cpp

XueleiFan · 2023-01-03T22:42:58Z

/integrate

openjdk · 2023-01-03T22:44:26Z

Going to push as commit 38cfc59.
Since your change was applied there have been 28 commits pushed to the master branch:

ea25a56: 8299520: TestPrintXML.java output error messages in case compare fails
92dfc73: 8294526: sun/security/provider/SubjectCodeSource.java no longer referenced
3d0db02: Merge
a6a903d: 8288204: GVN Crash: assert() failed: correct memory chain
37f8b05: 8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics
245f0cf: 8291302: ARM32: nmethod entry barriers support
a9ce772: 8299437: Make InetSocketAddressHolder shallowly immutable
8afd665: 8299395: Remove metaprogramming/removeCV.hpp
3757433: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
417d01e: 8299441: Fix typos in some test files under core-libs component
... and 18 more: https://git.openjdk.org/jdk/compare/11fd651ab1820770e3c65cd49589416098987a87...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-01-03T22:44:43Z

@XueleiFan Pushed as commit 38cfc59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Siedlerchr · 2023-01-04T11:40:23Z

@XueleiFan Unfortunately I still get the same error even after this PR was merged.

/Users/christophs/workspace/jdk/test/hotspot/jtreg/runtime/Thread/libAsyncExceptionOnMonitorEnter.cpp:37:3: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
  sprintf(name, "MyRawMonitor");
  ^

And looking at the file I still see the usage of sprintf:
https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/runtime/Thread/libAsyncExceptionOnMonitorEnter.cpp

Edit::
Another section:

/Users/christophs/workspace/jdk/test/hotspot/jtreg/serviceability/jvmti/events/ThreadEnd/threadend01/libthreadend01.cpp:59:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
    sprintf(name, "%s%d", prefix, eventsCount);
    ^

XueleiFan · 2023-01-04T15:45:19Z

@XueleiFan Unfortunately I still get the same error even after this PR was merged.

@Siedlerchr Would you please share the platform information? Thanks!

Siedlerchr · 2023-01-04T16:31:37Z

Ventura 13.1 (22C65)
SDK: MacOSX13.1.sdk (XCode 14.2)
macosx-aarch64-server-release

Full log (I commented out that line in libAsyncExceptionOnMonitorEnter, therefore the following came up)
I am happy to test any further fixes.

I run make run-test tier1 and did a clean before

=== Output from failing command(s) repeated here ===
* For target support_test_hotspot_jtreg_native_support_libthreadend01_libthreadend01.o:
/Users/christophs/workspace/jdk/test/hotspot/jtreg/serviceability/jvmti/events/ThreadEnd/threadend01/libthreadend01.cpp:59:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
    sprintf(name, "%s%d", prefix, eventsCount);
    ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
__deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                      ^
1 error generated.
* For target support_test_hotspot_jtreg_native_support_libthreadstart01_libthreadstart01.o:
/Users/christophs/workspace/jdk/test/hotspot/jtreg/serviceability/jvmti/events/ThreadStart/threadstart01/libthreadstart01.cpp:58:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
    sprintf(name, "%s%d", prefix, eventsCount);
    ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
__deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                      ^
1 error generated.

dholmes-ora · 2023-01-04T21:57:22Z

We have developers reporting the same, and other issues. I don't know what builds you used to test this but there are issues with at least opto code in hotspot and JVMTI tests (as above).

Siedlerchr · 2023-01-04T22:06:17Z

@dholmes-ora I am using the latest master branch from earlier today 82deb5c

XueleiFan · 2023-01-05T01:54:34Z

Ventura 13.1 (22C65) SDK: MacOSX13.1.sdk (XCode 14.2) macosx-aarch64-server-release

Full log (I commented out that line in libAsyncExceptionOnMonitorEnter, therefore the following came up) I am happy to test any further fixes.

I run make run-test tier1 and did a clean before

I could reproduce the issue. A new bug was filed: https://bugs.openjdk.org/browse/JDK-8299635. Thank you!

SWinxy · 2023-01-05T23:07:42Z

Oddly, this PR didn't solve it for me either. 8299635 should include the failure of libAsyncExceptionOnMonitorEnter.

8299378: sprintf is deprecated in Xcode 14

623b566

openjdk bot added the rfr Pull request is ready for review label Dec 28, 2022

openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 28, 2022

XueleiFan marked this pull request as draft December 28, 2022 06:02

openjdk bot removed the rfr Pull request is ready for review label Dec 28, 2022

include os

3d5f9d4

XueleiFan marked this pull request as ready for review December 28, 2022 18:43

openjdk bot added the rfr Pull request is ready for review label Dec 28, 2022

kimbarrett approved these changes Jan 2, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2023

dholmes-ora approved these changes Jan 3, 2023

View reviewed changes

test/hotspot/gtest/utilities/test_unsigned5.cpp Outdated Show resolved Hide resolved

sort includes alphabetically

59d4378

openjdk bot added the integrated Pull request has been integrated label Jan 3, 2023

openjdk bot closed this Jan 3, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2023

XueleiFan deleted the JDK-8299378 branch January 3, 2023 22:45

XueleiFan mentioned this pull request Jan 11, 2023

8299635: Hotspot update for deprecated sprintf in Xcode 14 #11935

Closed

3 tasks

Conversation

XueleiFan commented Dec 28, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Dec 28, 2022

Uh oh!

openjdk bot commented Dec 28, 2022

Uh oh!

mlbridge bot commented Dec 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

kimbarrett left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jan 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dholmes-ora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

XueleiFan commented Jan 3, 2023

Uh oh!

openjdk bot commented Jan 3, 2023

Uh oh!

openjdk bot commented Jan 3, 2023

Uh oh!

Siedlerchr commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XueleiFan commented Jan 4, 2023

Uh oh!

Siedlerchr commented Jan 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dholmes-ora commented Jan 4, 2023

Uh oh!

Siedlerchr commented Jan 4, 2023

Uh oh!

XueleiFan commented Jan 5, 2023

Uh oh!

SWinxy commented Jan 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

XueleiFan commented Dec 28, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented Dec 28, 2022 •

edited

Loading

openjdk bot commented Jan 2, 2023 •

edited

Loading

Siedlerchr commented Jan 4, 2023 •

edited

Loading

Siedlerchr commented Jan 4, 2023 •

edited

Loading