Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256201: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java failed #1180

Closed
wants to merge 1 commit into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Nov 12, 2020

The new test added in JDK-8211999 hits a bug on Linux (in mach5 it is passed on ubuntu 18.04 and failed on 20.04). The problem is that the bounds of the fullscreen frame include insets of the frame additionally to the screen size.

The behavior of the decorated full-screen window is not specified:
https://docs.oracle.com/en/java/javase/11/docs/api/java.desktop/java/awt/GraphicsDevice.html#setFullScreenWindow(java.awt.Window)

But it will be good to have the same cross-platform behavior. So I filed a separate bug to investigate the behavior of decorated frame in the fullscreen mode:
https://bugs.openjdk.java.net/browse/JDK-8256257


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8256201: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java failed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1180/head:pull/1180
$ git checkout pull/1180

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 12, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2020

@mrserb The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Nov 12, 2020
@mrserb mrserb marked this pull request as ready for review Nov 12, 2020
@openjdk openjdk bot added the rfr label Nov 12, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 12, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256201: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java failed

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 3e70aac: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)
  • c6ab0fd: 8255990: Bitmap region of dynamic CDS archive is not unmapped
  • 943acd2: 8256276: Temporarily disable gtest special_flags
  • 19bade0: 8256238: Remove Matcher::pass_original_key_for_aes
  • f7685a4: 8256203: Simplify RegMask::Empty
  • 70c7b1d: 8250607: C2: Filter type in PhiNode::Value() for induction variables of trip-counted integer loops
  • bd8693a: 8256181: Remove Allocation of old generation on alternate memory devices functionality
  • 4df8abc: 8255787: Tag container tests that use cGroups with cgroups keyword
  • ec08b3f: 8256188: Adjust output of make/autoconf/configure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 12, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 12, 2020

/integrate

@openjdk openjdk bot closed this Nov 12, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 12, 2020
@mrserb mrserb deleted the JDK-8256201 branch Nov 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 12, 2020

@mrserb Since your change was applied there have been 9 commits pushed to the master branch:

  • 3e70aac: 8254162: Implementation of Foreign-Memory Access API (Third Incubator)
  • c6ab0fd: 8255990: Bitmap region of dynamic CDS archive is not unmapped
  • 943acd2: 8256276: Temporarily disable gtest special_flags
  • 19bade0: 8256238: Remove Matcher::pass_original_key_for_aes
  • f7685a4: 8256203: Simplify RegMask::Empty
  • 70c7b1d: 8250607: C2: Filter type in PhiNode::Value() for induction variables of trip-counted integer loops
  • bd8693a: 8256181: Remove Allocation of old generation on alternate memory devices functionality
  • 4df8abc: 8255787: Tag container tests that use cGroups with cgroups keyword
  • ec08b3f: 8256188: Adjust output of make/autoconf/configure

Your commit was automatically rebased without conflicts.

Pushed as commit 1c0b490.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants