Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit #11805

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 30, 2022

On the old SLES12 ppc64le machine we do not have memory.memsw.limit_in_bytes :
ls -alL /sys/fs/cgroup/memory/memory.memsw.limit_in_bytes
ls: cannot access /sys/fs/cgroup/memory/memory.memsw.limit_in_bytes: No such file or directory

This leads to

[0.163s][trace][os,container] Memory and Swap Limit is: 18446744073709551614
memory_and_swap_limit_in_bytes: not supported

And the check in containers/docker/TestMemoryWithCgroupV1.java fails :

java.lang.RuntimeException: 'Memory and Swap Limit is: 157286400' missing from stdout/stderr
at jdk.test.lib.process.OutputAnalyzer.shouldContain(OutputAnalyzer.java:221)
at TestMemoryWithCgroupV1.testMemoryLimitWithSwappiness(TestMemoryWithCgroupV1.java:88)
at TestMemoryWithCgroupV1.main(TestMemoryWithCgroupV1.java:61)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:578)
at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
at java.base/java.lang.Thread.run(Thread.java:1623)

Probably we should handle this situation and check for "memory_and_swap_limit_in_bytes: not supported" or something similar .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11805/head:pull/11805
$ git checkout pull/11805

Update a local copy of the PR:
$ git checkout pull/11805
$ git pull https://git.openjdk.org/jdk pull/11805/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11805

View PR using the GUI difftool:
$ git pr show -t 11805

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11805.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 30, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 30, 2022
@openjdk
Copy link

openjdk bot commented Dec 30, 2022

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Dec 30, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 30, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299424: containers/docker/TestMemoryWithCgroupV1.java fails on SLES12 ppc64le when testing Memory and Swap Limit

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 18ff1f5: 6257207: JTable.getDefaultEditor throws NullPointerException
  • 2ee34f1: 4912623: GTK L&F: Folder list of the JFileChooser is allowing multiple selection unlike native

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2023
@MBaesken
Copy link
Member Author

MBaesken commented Jan 2, 2023

Hi Martin, thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

Going to push as commit 95d4db3.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 18ff1f5: 6257207: JTable.getDefaultEditor throws NullPointerException
  • 2ee34f1: 4912623: GTK L&F: Folder list of the JFileChooser is allowing multiple selection unlike native

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 2, 2023
@openjdk openjdk bot closed this Jan 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@MBaesken Pushed as commit 95d4db3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants