Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298876: Swing applications do not get repainted coming out of sleep on Windows 10 #11808

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 2, 2023

This is a revert of commit 415bf44
which was a fix for 8275715: D3D pipeline processes multiple PaintEvent at initial drawing
as it is causing some repaint issue and also since the regression test is known to fail in some systems and is currently problemlisted which suggests the fix was half-baked.

Raised a new issue for the same https://bugs.openjdk.org/browse/JDK-8299436


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298876: Swing applications do not get repainted coming out of sleep on Windows 10

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11808/head:pull/11808
$ git checkout pull/11808

Update a local copy of the PR:
$ git checkout pull/11808
$ git pull https://git.openjdk.org/jdk pull/11808/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11808

View PR using the GUI difftool:
$ git pr show -t 11808

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11808.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 2, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 2, 2023

Webrevs

@mrserb
Copy link
Member

mrserb commented Jan 2, 2023

I suggest getting confirmation from Andy that this change will actually fix the problem.

Copy link

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue disappears with this change. Many thanks!

@openjdk
Copy link

openjdk bot commented Jan 5, 2023

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298876: Swing applications do not get repainted coming out of sleep on Windows 10

Reviewed-by: angorya, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • a49ccb9: 8299292: Missing elements in aliased String array
  • b908388: 8298449: Unnecessary Vector usage in MetaData.ProxyPersistenceDelegate
  • be64bf8: 8299329: Assertion failure with fastdebug build when trying to use CDS without classpath
  • 8723847: 8298848: C2: clone all of (CmpP (LoadKlass (AddP down at split if
  • 1ca31d3: 8299657: sun/tools/jhsdb/SAGetoptTest.java fails after 8299470
  • e7361cb: 8299430: Cleanup: delete unnecessary semicolons in java.desktop module
  • c929d8b: 8299475: Enhance SocketException by cause where it is missing in net and nio area
  • 2ccdefc: 8299470: sun/jvm/hotspot/SALauncher.java handling of negative rmiport args
  • 578c287: 8081507: Open or Save button in JFileChooser has OK title in GTK LaF
  • 5ae6de8: 8299296: Write a test to verify the components selection sends ItemEvent
  • ... and 44 more: https://git.openjdk.org/jdk/compare/c2e3d7284814cd6b49f44b4de18e0f92310422b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 5, 2023
@mrserb
Copy link
Member

mrserb commented Jan 6, 2023

Since this is just a revert what about fixing it in jdk20?

@@ -1,86 +0,0 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test should be removed from the problem list as well.

@prrace
Copy link
Contributor

prrace commented Jan 6, 2023

Since this is just a revert what about fixing it in jdk20?

If it had been introduced in 20 we likely would but it was introduced in 19.

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Jan 9, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2023

Going to push as commit 4072412.
Since your change was applied there have been 94 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2023
@openjdk openjdk bot closed this Jan 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2023
@openjdk
Copy link

openjdk bot commented Jan 9, 2023

@prsadhuk Pushed as commit 4072412.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8298876 branch January 9, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants