Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8299479: Remove metaprogramming/decay.hpp #11816

Closed
wants to merge 5 commits into from

Conversation

jcking
Copy link
Contributor

@jcking jcking commented Jan 2, 2023

Code cleanup of pre-C++11 <type_traits> implementations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11816/head:pull/11816
$ git checkout pull/11816

Update a local copy of the PR:
$ git checkout pull/11816
$ git pull https://git.openjdk.org/jdk pull/11816/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11816

View PR using the GUI difftool:
$ git pr show -t 11816

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11816.diff

Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2023

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Signed-off-by: Justin King <jcking@google.com>
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 2, 2023
@jcking
Copy link
Contributor Author

jcking commented Jan 2, 2023

@kimbarrett Another one.

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@jcking The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 2, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 2, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@jcking this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout remove-decay
git fetch https://git.openjdk.org/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jan 3, 2023
@jcking jcking requested a review from tschatzl January 3, 2023 14:30
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299479: Remove metaprogramming/decay.hpp

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ea25a56: 8299520: TestPrintXML.java output error messages in case compare fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Jan 3, 2023
@jcking
Copy link
Contributor Author

jcking commented Jan 3, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@jcking
Your change (at version 131c7fd) is now ready to be sponsored by a Committer.

Signed-off-by: Justin King <jcking@google.com>
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Jan 3, 2023
@jcking
Copy link
Contributor Author

jcking commented Jan 3, 2023

Forgot to remove the actual header apparently, updated.

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jcking
Copy link
Contributor Author

jcking commented Jan 3, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@jcking
Your change (at version bfae998) is now ready to be sponsored by a Committer.

@kimbarrett
Copy link

/integrate

@openjdk
Copy link

openjdk bot commented Jan 7, 2023

@kimbarrett Only the author (@jcking) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@kimbarrett
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 11, 2023

Going to push as commit 10a747c.
Since your change was applied there have been 101 commits pushed to the master branch:

  • ddca2b9: 8299701: Remove unused GCCause::_wb_conc_mark
  • c595f96: 8299278: tools/jpackage/share/AddLauncherTest.java#id1 failed AddLauncherTest.bug8230933
  • 3c99e78: 8298735: Some tools/jpackage/windows/* tests fails with jtreg test timeout
  • 5a51ef2: 8297874: get_dump_directory() in jfrEmergencyDump.cpp should pass correct length to jio_snprintf
  • a86b6f6: 8299183: Invokers.checkExactType passes parameters to create WMTE in opposite order
  • 8b0133f: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE
  • d68de02: 8299845: Remove obsolete comments in DirtyCardToOopClosure::get_actual_top
  • debe587: 8298381: Improve handling of session tickets for multiple SSLContexts
  • eab1e62: 8297487: G1 Remark: no need to keep alive oop constants of nmethods on stack
  • c8a8388: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • ... and 91 more: https://git.openjdk.org/jdk/compare/92dfc735f2297441a99b3e39464fb8f77a354d55...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 11, 2023
@openjdk openjdk bot closed this Jan 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@kimbarrett @jcking Pushed as commit 10a747c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants