JDK-8299481: Remove metaprogramming/removePointer.hpp

[jcking]

Code cleanup of pre-C++11 <type_traits> implementations.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299481: Remove metaprogramming/removePointer.hpp

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to 33dc873a

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11817/head:pull/11817
$ git checkout pull/11817

Update a local copy of the PR:
$ git checkout pull/11817
$ git pull https://git.openjdk.org/jdk pull/11817/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11817

View PR using the GUI difftool:
$ git pr show -t 11817

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11817.diff

[bridgekeeper]

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jcking To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[jcking]

/label hotspot

[jcking]

@kimbarrett Another one.

[openjdk]

@jcking
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 01: Full (161cc56c)
• 00: Full (33dc873a)

[kimbarrett]

Looks good, and trivial.

[openjdk]

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299481: Remove metaprogramming/removePointer.hpp

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• 3e2314d: 8299254: Support dealing with standard assert macro
• a49ccb9: 8299292: Missing elements in aliased String array
• b908388: 8298449: Unnecessary Vector usage in MetaData.ProxyPersistenceDelegate
• be64bf8: 8299329: Assertion failure with fastdebug build when trying to use CDS without classpath
• 8723847: 8298848: C2: clone all of (CmpP (LoadKlass (AddP down at split if
• 1ca31d3: 8299657: sun/tools/jhsdb/SAGetoptTest.java fails after 8299470
• e7361cb: 8299430: Cleanup: delete unnecessary semicolons in java.desktop module
• c929d8b: 8299475: Enhance SocketException by cause where it is missing in net and nio area
• 2ccdefc: 8299470: sun/jvm/hotspot/SALauncher.java handling of negative rmiport args
• 578c287: 8081507: Open or Save button in JFileChooser has OK title in GTK LaF
• ... and 22 more: https://git.openjdk.org/jdk/compare/92dfc735f2297441a99b3e39464fb8f77a354d55...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kimbarrett, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jcking]

/integrate

[openjdk]

@jcking
Your change (at version 33dc873) is now ready to be sponsored by a Committer.

[tschatzl]

/sponsor

[openjdk]

@tschatzl @jcking Since your change was applied there have been 4 commits pushed to the master branch:

• 8afd665: 8299395: Remove metaprogramming/removeCV.hpp
• 3757433: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
• 417d01e: 8299441: Fix typos in some test files under core-libs component
• 5b5552f: 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

It was not possible to rebase your changes automatically. Please merge master into your branch and try again.

[jcking]

/integrate

[openjdk]

@jcking
Your change (at version 161cc56) is now ready to be sponsored by a Committer.

[kimbarrett]

/sponsor

[openjdk]

Going to push as commit d53cac3.
Since your change was applied there have been 62 commits pushed to the master branch:

• 834e50e: 8298921: Create a regression test for JDK-8139581
• e209693: 8258776: ThreadLocal#initialValue() Javadoc is unaware of ThreadLocal#withInitial()
• d5b80ab: 8299617: CurrencySymbols.properties is missing the copyright notice
• 63cf4aa: 8299499: Usage of constructors of primitive wrapper classes should be avoided in java.net API docs
• 5393dc9: Merge
• 1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
• 5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
• 136f5db: 8299528: IR test: TestEor3AArch64.java fails on aarch64
• 284c94e: 8298525: javadoc crashes with "UnsupportedOperationException: Not yet implemented" in SeeTaglet.inherit
• 9c4ed16: 8299561: VaList.empty() doesn't return a list associated with the global scope
• ... and 52 more: https://git.openjdk.org/jdk/compare/92dfc735f2297441a99b3e39464fb8f77a354d55...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett @jcking Pushed as commit d53cac3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.