Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java #11819

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jan 2, 2023

Simple problem listing to clear up noise in our CI

Manually tested:

jtreg -a -v:fail,error,time -retain:all -ignore:quiet -exclude:ProblemList.txt -noreport -timeout:15 -J-Djavatest.maxOutputSize=10000000 -testjdk:./build/linux-x64-debug-8299483/images/jdk java/text/Format/NumberFormat/CurrencyFormat.java
Test results: no tests selected

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11819/head:pull/11819
$ git checkout pull/11819

Update a local copy of the PR:
$ git checkout pull/11819
$ git pull https://git.openjdk.org/jdk pull/11819/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11819

View PR using the GUI difftool:
$ git pr show -t 11819

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11819.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2023

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dholmes-ora
Copy link
Member Author

/integrate auto

@openjdk openjdk bot added rfr Pull request is ready for review auto labels Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@dholmes-ora This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 2, 2023

Going to push as commit 5b5552f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 2, 2023
@openjdk openjdk bot closed this Jan 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 2, 2023
@openjdk
Copy link

openjdk bot commented Jan 2, 2023

@openjdk[bot] Pushed as commit 5b5552f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8299483 branch June 27, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto integrated Pull request has been integrated
2 participants