Skip to content

4934362: see also refers to self #11820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 3, 2023

Some methods and constants has a hyperreference to self in javadoc which is rectified to reference proper methods


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11820/head:pull/11820
$ git checkout pull/11820

Update a local copy of the PR:
$ git checkout pull/11820
$ git pull https://git.openjdk.org/jdk pull/11820/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11820

View PR using the GUI difftool:
$ git pr show -t 11820

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11820.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@prsadhuk The following labels will be automatically applied to this pull request:

  • client
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client client-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 3, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 5, 2023

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4934362: see also refers to self

Reviewed-by: prr, serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 433 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 5, 2023
@@ -527,7 +526,7 @@ public boolean checkID(int id) {
* @return {@code true} if all images have finished loading,
* have been aborted, or have encountered
* an error; {@code false} otherwise
* @see java.awt.MediaTracker#checkID(int, boolean)
* @see java.awt.MediaTracker#checkID(int, boolean, boolean)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int, boolean, boolean is a private method, it should probably refer the checkID(int)

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Feb 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 6, 2023

Going to push as commit ab528ce.
Since your change was applied there have been 557 commits pushed to the master branch:

  • 8f195ff: 8298952: All nodes should have type(n) == Value(n) after IGVN
  • e88fd8c: 8301768: G1: Remove unimplemented HeapRegionRemSet::split_card
  • 96c50a3: 8301752: [IR Framework] Add more IR framework examples
  • 3646c4e: 8301171: Rename sanitizers/address.h to sanitizers/address.hpp
  • 3f3356b: 8301760: Fix possible leak in SpNegoContext dispose
  • b4cb6c8: 8301743: RISC-V: Add InlineSkippedInstructionsCounter to post-call nops
  • 4dd6e8f: 8301740: RISC-V: Address::uses() should check address mode
  • 8507db1: 8301628: RISC-V: c2 fix pipeline class for several instructions
  • d67bfe2: 8301342: Prefer ArrayList to LinkedList in LayoutComparator
  • 3449324: 8301396: Port fdlibm expm1 to Java
  • ... and 547 more: https://git.openjdk.org/jdk/compare/ce6395a1356a3d1334aeffc70ac8e4f86dd81a4c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2023
@openjdk openjdk bot closed this Feb 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@prsadhuk Pushed as commit ab528ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-4934362 branch February 6, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants