8299326: LinkResolver::resolve_field resolved_klass cannot be null

[coleenp]

Removed the code checking for null and add an assert for the creation of LinkInfo that the resolved_klass can't be null. Use delegating constructors for LinkInfo.
Tested with tier1-7.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299326: LinkResolver::resolve_field resolved_klass cannot be null

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11832/head:pull/11832
$ git checkout pull/11832

Update a local copy of the PR:
$ git checkout pull/11832
$ git pull https://git.openjdk.org/jdk pull/11832/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11832

View PR using the GUI difftool:
$ git pr show -t 11832

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11832.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0d26e6c1)

[iklam]

LGTM.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299326: LinkResolver::resolve_field resolved_klass cannot be null

Reviewed-by: iklam, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• ea25a56: 8299520: TestPrintXML.java output error messages in case compare fails
• 92dfc73: 8294526: sun/security/provider/SubjectCodeSource.java no longer referenced
• 3d0db02: Merge
• a6a903d: 8288204: GVN Crash: assert() failed: correct memory chain
• 37f8b05: 8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics
• 245f0cf: 8291302: ARM32: nmethod entry barriers support
• a9ce772: 8299437: Make InetSocketAddressHolder shallowly immutable
• 8afd665: 8299395: Remove metaprogramming/removeCV.hpp
• 3757433: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
• 417d01e: 8299441: Fix typos in some test files under core-libs component
• ... and 37 more: https://git.openjdk.org/jdk/compare/b378381a9c5abf555c4ccf87d387d2cd77196e04...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks, Ioi!

[fparain]

Looks good to me.

[coleenp]

Thanks Fred.

[coleenp]

/integrate

[openjdk]

Going to push as commit ccbcea8.
Since your change was applied there have been 52 commits pushed to the master branch:

• e3035ba: 8299079: Better interface nmethod oop accesses
• 41900b5: 8189338: JMX RMI Remote Mbean server connection hangs if the server stops responding during a SSL Handshake
• 82deb5c: 8298601: Refactor archiving of java.lang.Module objects
• 77ff197: 7030853: JDK 7 Serializable Swing classes not compatible with JDK 6
• 38cfc59: 8299378: sprintf is deprecated in Xcode 14
• ea25a56: 8299520: TestPrintXML.java output error messages in case compare fails
• 92dfc73: 8294526: sun/security/provider/SubjectCodeSource.java no longer referenced
• 3d0db02: Merge
• a6a903d: 8288204: GVN Crash: assert() failed: correct memory chain
• 37f8b05: 8298592: Add java man page documentation for ChaCha20 and Poly1305 intrinsics
• ... and 42 more: https://git.openjdk.org/jdk/compare/b378381a9c5abf555c4ccf87d387d2cd77196e04...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit ccbcea8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.