8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR #11833

justin-curtis-lu · 2023-01-03T17:40:42Z

Regression caused by the fix to JDK-8296239. The ISO 4217 Amendment 174 Update changes went into effect starting in 2023.

java/text/Format/NumberFormat/CurrencyFormat.java fails as java/text/Format/NumberFormat/CurrencySymbols.properties did not have the proper change from the Amendment 174 update as well.

Swapping the outdated Kn to EUR matches the Amendment 174 update, and fixes the failing test.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR

Reviewers

Naoto Sato (@naotoj - Reviewer)
Lance Andersen (@LanceAndersen - Reviewer) ⚠️ Review applies to 0934f837
Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11833/head:pull/11833
$ git checkout pull/11833

Update a local copy of the PR:
$ git checkout pull/11833
$ git pull https://git.openjdk.org/jdk pull/11833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11833

View PR using the GUI difftool:
$ git pr show -t 11833

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11833.diff

bridgekeeper · 2023-01-03T17:42:18Z

👋 Welcome back justin-curtis-lu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-01-03T17:45:24Z

@justin-curtis-lu The following labels will be automatically applied to this pull request:

core-libs
i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-01-03T17:48:35Z

Webrevs

AlanBateman · 2023-01-03T17:51:16Z

You will need to remove the test from test/jdk/ProblemList.txt to get it to run again.

naotoj

You could also clean-up older entries that use transition format, i.e., lt_LT and lv_LV.

naotoj · 2023-01-03T17:51:26Z

test/jdk/java/text/Format/NumberFormat/CurrencySymbols.properties

@@ -79,7 +79,7 @@ fr_FR=\u20AC
 fr_LU=\u20AC
 hi_IN=\u0930\u0942
 hr=\u00A4
-hr_HR=Kn
+hr_HR=EUR


Since this is a table for currency symbols, it has to be EURO SIGN ('\u20AC')

Made those changes, thank you

LanceAndersen

Looks OK to me

openjdk · 2023-01-03T20:25:22Z

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR

Reviewed-by: naoto, lancea, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

7dcc689: 8299563: Fix typos
44be5ed: 8219810: javac throws NullPointerException
b9758d2: 8200610: Compiling fails with java.nio.file.ReadOnlyFileSystemException
df1caf9: Merge
a17f505: 8299476: PPC64 Zero build fails after JDK-8286302
b743519: 8293824: gc/whitebox/TestConcMarkCycleWB.java failed "RuntimeException: assertTrue: expected true, was false"
8254cbb: 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java
031829d: 8298324: Unable to run shell test with make
3eb85d1: 8299235: broken link referencing missing id
6a07fd0: 8155259: Suspicious buffer allocation in com.sun.tools.javac.file.BaseFileManager
... and 9 more: https://git.openjdk.org/jdk/compare/ea25a561c57cba63c5581aefa21f92ffd7386244...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @LanceAndersen, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

naotoj · 2023-01-03T20:44:48Z

src/jdk.localedata/share/classes/sun/util/resources/ext/CurrencyNames_hr_HR.properties

@@ -35,4 +35,5 @@
 # This notice and attribution to Taligent may not be removed.
 # Taligent is a registered trademark of Taligent, Inc.

+EUR=\u20AC


Good catch!

justin-curtis-lu · 2023-01-04T21:49:34Z

/integrate

openjdk · 2023-01-04T21:51:14Z

@justin-curtis-lu
Your change (at version d0d075c) is now ready to be sponsored by a Committer.

naotoj · 2023-01-04T21:57:07Z

/sponsor

openjdk · 2023-01-04T21:59:12Z

Going to push as commit 3b374c0.
Since your change was applied there have been 19 commits pushed to the master branch:

7dcc689: 8299563: Fix typos
44be5ed: 8219810: javac throws NullPointerException
b9758d2: 8200610: Compiling fails with java.nio.file.ReadOnlyFileSystemException
df1caf9: Merge
a17f505: 8299476: PPC64 Zero build fails after JDK-8286302
b743519: 8293824: gc/whitebox/TestConcMarkCycleWB.java failed "RuntimeException: assertTrue: expected true, was false"
8254cbb: 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java
031829d: 8298324: Unable to run shell test with make
3eb85d1: 8299235: broken link referencing missing id
6a07fd0: 8155259: Suspicious buffer allocation in com.sun.tools.javac.file.BaseFileManager
... and 9 more: https://git.openjdk.org/jdk/compare/ea25a561c57cba63c5581aefa21f92ffd7386244...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-01-04T21:59:29Z

@naotoj @justin-curtis-lu Pushed as commit 3b374c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Switch symbol to EUR for hr_HR

0ada206

openjdk bot added the rfr Pull request is ready for review label Jan 3, 2023

openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 3, 2023

naotoj suggested changes Jan 3, 2023

View reviewed changes

Remove from list, fix symbol

0934f83

LanceAndersen approved these changes Jan 3, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 3, 2023

naotoj approved these changes Jan 3, 2023

View reviewed changes

Update copyright

d0d075c

naotoj approved these changes Jan 3, 2023

View reviewed changes

jaikiran approved these changes Jan 4, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 4, 2023

openjdk bot added the integrated Pull request has been integrated label Jan 4, 2023

openjdk bot closed this Jan 4, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR #11833

8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR #11833

justin-curtis-lu commented Jan 3, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 3, 2023

openjdk bot commented Jan 3, 2023

mlbridge bot commented Jan 3, 2023 •

edited

Loading

AlanBateman commented Jan 3, 2023

naotoj left a comment

naotoj Jan 3, 2023

justin-curtis-lu Jan 3, 2023

LanceAndersen left a comment

openjdk bot commented Jan 3, 2023 •

edited

Loading

naotoj Jan 3, 2023

justin-curtis-lu commented Jan 4, 2023

openjdk bot commented Jan 4, 2023

naotoj commented Jan 4, 2023

openjdk bot commented Jan 4, 2023

openjdk bot commented Jan 4, 2023

8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR #11833

8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR #11833

Conversation

justin-curtis-lu commented Jan 3, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jan 3, 2023

openjdk bot commented Jan 3, 2023

mlbridge bot commented Jan 3, 2023 • edited Loading

Webrevs

AlanBateman commented Jan 3, 2023

naotoj left a comment

Choose a reason for hiding this comment

naotoj Jan 3, 2023

Choose a reason for hiding this comment

justin-curtis-lu Jan 3, 2023

Choose a reason for hiding this comment

LanceAndersen left a comment

Choose a reason for hiding this comment

openjdk bot commented Jan 3, 2023 • edited Loading

naotoj Jan 3, 2023

Choose a reason for hiding this comment

justin-curtis-lu commented Jan 4, 2023

openjdk bot commented Jan 4, 2023

naotoj commented Jan 4, 2023

openjdk bot commented Jan 4, 2023

openjdk bot commented Jan 4, 2023

justin-curtis-lu commented Jan 3, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Jan 3, 2023 •

edited

Loading

openjdk bot commented Jan 3, 2023 •

edited

Loading