8299553: Make ScaledEtchedBorderTest.java comprehensive

[aivanov-jdk]

The ScaledEtchedBorderTest.java test (JDK-8279614) verifies that the thickness of lines of EtchedBorder is consistent. The component inside had the same background color as the frame. Yet if there's another component the background of which is different, that background could be seen.

The updated test covers the scenario reported in JDK-8294921.

The bug itself is fixed by refactoring JDK-8294680 the border rendering code which uses a more precise coordinate calculation, see #11571. Thus, I contribute the test under a separate bugid.

I also modified ScaledLineBorderTest.java so that the location of the child panels is saved when they're created as done in ScaledTextFieldBorderTest.java in #11498. I removed the unused Component import after this modification from both tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299553: Make ScaledEtchedBorderTest.java comprehensive

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to b78389e8
• Harshitha Onkar (@honkar-jdk - Committer)
• Alisen Chung (@alisenchung - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11836/head:pull/11836
$ git checkout pull/11836

Update a local copy of the PR:
$ git checkout pull/11836
$ git pull https://git.openjdk.org/jdk pull/11836/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11836

View PR using the GUI difftool:
$ git pr show -t 11836

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11836.diff

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (f7783e43)
• 00: Full (b78389e8)

[mrserb]

Don't you need to close the JDK-8294921 since it was fixed already?

[honkar-jdk]

Don't you need to close the JDK-8294921 since it was fixed already?

This issue has been closed now.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299553: Make ScaledEtchedBorderTest.java comprehensive

Reviewed-by: serb, honkar, achung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 44be5ed: 8219810: javac throws NullPointerException
• b9758d2: 8200610: Compiling fails with java.nio.file.ReadOnlyFileSystemException
• df1caf9: Merge
• a17f505: 8299476: PPC64 Zero build fails after JDK-8286302
• b743519: 8293824: gc/whitebox/TestConcMarkCycleWB.java failed "RuntimeException: assertTrue: expected true, was false"
• 8254cbb: 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java
• 031829d: 8298324: Unable to run shell test with make
• 3eb85d1: 8299235: broken link referencing missing id
• 6a07fd0: 8155259: Suspicious buffer allocation in com.sun.tools.javac.file.BaseFileManager
• 4c0f24e: 8064931: tools/javac/scope/DupUnsharedTest.java needs to be updated to add the bug id
• ... and 8 more: https://git.openjdk.org/jdk/compare/ea25a561c57cba63c5581aefa21f92ffd7386244...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[honkar-jdk]

Tested all 3 tests, it works as expected.
Minor inline suggestions added that are applicable for all 3 tests.

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit 558d610.
Since your change was applied there have been 272 commits pushed to the master branch:

• 80ab50b: 8294680: Refactor scaled border rendering
• b317658: 8300399: EdDSA does not verify when there is no message
• d85243f: 8300647: Miscellaneous hashCode improvements in java.base
• 453dbd1: 8298377: JfrVframeStream causes deadlocks in ZGC
• 1084fd2: 8299973: Replace NULL with nullptr in share/utilities/
• dea58ef: 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems
• 2e4a3c4: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null'
• e326b86: 8300042: Improve CPU related JFR events descriptions
• 11df6eb: 8300540: Serial: Remove obsolete comments in GenMarkSweep
• 8f7faa6: 8300447: Parallel: Refactor PSPromotionManager::drain_stacks_depth
• ... and 262 more: https://git.openjdk.org/jdk/compare/ea25a561c57cba63c5581aefa21f92ffd7386244...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit 558d610.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.