Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299439: [testbug] java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR after 1.1.2023 and 8296239 #11844

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 4, 2023

…fails for hr_HR after 1.1.2023 and 8296239

Hi,

this fixes the issue with the currency test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299439: [testbug] java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR after 1.1.2023 and 8296239

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11844/head:pull/11844
$ git checkout pull/11844

Update a local copy of the PR:
$ git checkout pull/11844
$ git pull https://git.openjdk.org/jdk pull/11844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11844

View PR using the GUI difftool:
$ git pr show -t 11844

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11844.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8299439: [testbug] java/text/Format/NumberFormat/CurrencyFormat.java … 8299439: [testbug] java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR after 1.1.2023 and 8296239 Jan 4, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2023
@openjdk
Copy link

openjdk bot commented Jan 4, 2023

@GoeLin The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 4, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2023

Webrevs

@AlanBateman
Copy link
Contributor

AlanBateman commented Jan 4, 2023

Should this be closed as dup of pull/11833 ?

@GoeLin
Copy link
Member Author

GoeLin commented Jan 4, 2023

@AlanBateman, sorry, I missed that other PR.

@GoeLin GoeLin closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants