8299608: Add Register + imm32 orq to x86_64 assembler

[fisk]

The current x86_64 orq Register + imm32 uses emit_arith, which is rather clever and checks if it can use imm8 instead. However, sometimes you really want it to be imm32 regardless, for example if you are going to patch the code. Such functionality should be added.

Since there seems to be a precedent distinguishing this with testl_imm32(Register, imm32) vs testl(Register, imm32), my proposed patch similarly adds an orq_imm32 that uses emit_arith_imm32.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299608: Add Register + imm32 orq to x86_64 assembler

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to c7f6e63c
• Sandhya Viswanathan (@sviswa7 - Reviewer) ⚠️ Review applies to c7f6e63c
• Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to c7f6e63c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11850/head:pull/11850
$ git checkout pull/11850

Update a local copy of the PR:
$ git checkout pull/11850
$ git pull https://git.openjdk.org/jdk pull/11850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11850

View PR using the GUI difftool:
$ git pr show -t 11850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11850.diff

[bridgekeeper]

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fisk The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c5a0a1e9)
• 00: Full (c7f6e63c)

[shipilev]

Looks okay.

(Also, it is that time of the year when even the simplest patches come with copyright year updates...)

[openjdk]

@fisk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299608: Add Register + imm32 orq to x86_64 assembler

Reviewed-by: shade, sviswanathan, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 8723847: 8298848: C2: clone all of (CmpP (LoadKlass (AddP down at split if
• 1ca31d3: 8299657: sun/tools/jhsdb/SAGetoptTest.java fails after 8299470
• e7361cb: 8299430: Cleanup: delete unnecessary semicolons in java.desktop module
• c929d8b: 8299475: Enhance SocketException by cause where it is missing in net and nio area
• 2ccdefc: 8299470: sun/jvm/hotspot/SALauncher.java handling of negative rmiport args
• 578c287: 8081507: Open or Save button in JFileChooser has OK title in GTK LaF
• 5ae6de8: 8299296: Write a test to verify the components selection sends ItemEvent
• 3b374c0: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
• 7dcc689: 8299563: Fix typos
• 44be5ed: 8219810: javac throws NullPointerException
• ... and 12 more: https://git.openjdk.org/jdk/compare/e3035bad60dfa71e9c24fcc509cd7f07eb2bf62e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sviswa7]

LGTM

[vnkozlov]

Good.

[fisk]

Thanks for the reviews @shipilev, @sviswa7 and @vnkozlov!

[fisk]

/integrate

[openjdk]

Going to push as commit a503ec2.
Since your change was applied there have been 64 commits pushed to the master branch:

• d2827ec: 8299671: speed up compiler/intrinsics/string/TestStringLatin1IndexOfChar.java
• 05a0a71: 8297933: [REDO] Compiler should only use verified interface types for optimization
• 9b1ade8: 8295406: C1 crash with -XX:TypeProfileArgsLimit=0 -XX:TypeProfileLevel=222
• 8d17d1e: 6914801: IPv6 unavailable if stdin is a socket
• d03a5d9: 8299593: getprotobyname should not be used
• c444922: 8218474: JComboBox display issue with GTKLookAndFeel
• 7607c07: 8299774: SYNTH_BUTTON_UI_KEY field is unused
• d53cac3: 8299481: Remove metaprogramming/removePointer.hpp
• 834e50e: 8298921: Create a regression test for JDK-8139581
• e209693: 8258776: ThreadLocal#initialValue() Javadoc is unaware of ThreadLocal#withInitial()
• ... and 54 more: https://git.openjdk.org/jdk/compare/e3035bad60dfa71e9c24fcc509cd7f07eb2bf62e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fisk Pushed as commit a503ec2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.