Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299617: CurrencySymbols.properties is missing the copyright notice #11854

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jan 4, 2023

Added the missing copyright header


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299617: CurrencySymbols.properties is missing the copyright notice

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11854/head:pull/11854
$ git checkout pull/11854

Update a local copy of the PR:
$ git checkout pull/11854
$ git pull https://git.openjdk.org/jdk pull/11854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11854

View PR using the GUI difftool:
$ git pr show -t 11854

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11854.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2023

👋 Welcome back justin-curtis-lu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 4, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 4, 2023
@@ -1,3 +1,28 @@
#
# Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not new, so I'd use 2001 as the year created, which is borrowed from the test body CurrencyFormat.java.

Comment on lines 7 to 9
# published by the Free Software Foundation. Oracle designates this
# particular file as subject to the "Classpath" exception as provided
# by Oracle in the LICENSE file that accompanied this code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classpath exception is not applicable to tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not know that, thank you. Made the fixes for this and your previous comment.

@justin-curtis-lu justin-curtis-lu marked this pull request as ready for review January 5, 2023 22:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2023

Webrevs

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided GPL license appear to match the standard template available here:

https://github.com/openjdk/jdk/blob/master/make/data/license-templates/gpl-header

@openjdk
Copy link

openjdk bot commented Jan 5, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299617: CurrencySymbols.properties is missing the copyright notice

Reviewed-by: naoto, iris, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 7310131: 8299337: The java.awt.image.ColorModel#pData field is unused
  • d086e82: 8299600: Use Objects.check*() where appropriate in java.io
  • 4a95c74: 8299425: "LCMSImageLayout.isIntPacked" flag can be deleted
  • d6d6eb4: 8299699: Test runtime/cds/appcds/WrongClasspath.java fails after JDK-8299329
  • 8c70bf3: 8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs
  • d6e9f01: 8285416: [LOOM] Some nsk/jdi tests fail due to needing too many virtual threads
  • ba03f42: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo
  • 3dcf700: 8299336: InputStream::DEFAULT_BUFFER_SIZE should be 16384
  • 1e99729: 8299274: Add elements to resolved_references consistently
  • 8cc1669: 8299721: [Vector API] assert in switch-default of LibraryCallKit::arch_supports_vector_rotate is too weak to catch bugs
  • ... and 23 more: https://git.openjdk.org/jdk/compare/44be5edf5aa661169c665aa9386e5930a3632524...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @irisclark, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 5, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 7, 2023
@openjdk
Copy link

openjdk bot commented Jan 7, 2023

@justin-curtis-lu
Your change (at version b4356c4) is now ready to be sponsored by a Committer.

@jaikiran
Copy link
Member

jaikiran commented Jan 7, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 7, 2023

Going to push as commit d5b80ab.
Since your change was applied there have been 40 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 7, 2023
@openjdk openjdk bot closed this Jan 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 7, 2023
@openjdk
Copy link

openjdk bot commented Jan 7, 2023

@jaikiran @justin-curtis-lu Pushed as commit d5b80ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
4 participants