8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs #11884

justin-curtis-lu · 2023-01-06T17:42:53Z

Removed constructors of primitive wrapper classes (deprecated for removal) for the following

java.text.ChoiceFormat
java.text.MessageFormat

Replaced with .valueOf() method

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs

Reviewers

Naoto Sato (@naotoj - Reviewer) ⚠️ Review applies to d6332659
Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11884/head:pull/11884
$ git checkout pull/11884

Update a local copy of the PR:
$ git checkout pull/11884
$ git pull https://git.openjdk.org/jdk pull/11884/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11884

View PR using the GUI difftool:
$ git pr show -t 11884

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11884.diff

bridgekeeper · 2023-01-06T17:44:10Z

👋 Welcome back justin-curtis-lu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-01-06T17:47:07Z

@justin-curtis-lu The following labels will be automatically applied to this pull request:

core-libs
i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-01-06T17:51:08Z

Webrevs

01: Full - Incremental (cf833aee)
00: Full (d6332659)

naotoj

LGTM

naotoj · 2023-01-06T18:36:08Z

src/java.base/share/classes/java/text/MessageFormat.java

@@ -307,12 +307,12 @@
 * will be the final result of the parsing.  For example,
 * <blockquote><pre>
 * MessageFormat mf = new MessageFormat("{0,number,#.##}, {0,number,#.#}");
- * Object[] objs = {new Double(3.1415)};
+ * Object[] objs = {Double.valueOf(3.1415)};
 * String result = mf.format( objs );
 * // result now equals "3.14, 3.1"
 * objs = null;


Although this is not related to this fix, this line objs = null is not needed (and is confusing as an example snippet). I'd remove this.

Makes sense, just got rid of it

openjdk · 2023-01-06T18:43:05Z

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs

Reviewed-by: naoto, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

bfd5971: 8299757: Update JCov version to 3.0.14
17a3f0e: 8299275: Add some ClassLoaderData verification code
4ba8122: 8299312: Clean up BarrierSetNMethod
66db0bb: 8299692: G1: Remove unused G1BlockOffsetTable::is_card_boundary
7068457: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options
500c3c1: 8298730: Refactor subsystem_file_line_contents and add docs and tests
4072412: 8298876: Swing applications do not get repainted coming out of sleep on Windows 10
a503ec2: 8299608: Add Register + imm32 orq to x86_64 assembler
d2827ec: 8299671: speed up compiler/intrinsics/string/TestStringLatin1IndexOfChar.java
05a0a71: 8297933: [REDO] Compiler should only use verified interface types for optimization
... and 49 more: https://git.openjdk.org/jdk/compare/44be5edf5aa661169c665aa9386e5930a3632524...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

LanceAndersen

Looks fine Justin, thanks for doing this.

At some point we should convert the examples to be a snippet which we can do at a later time

justin-curtis-lu · 2023-01-06T19:19:54Z

Looks fine Justin, thanks for doing this.

At some point we should convert the examples to be a snippet which we can do at a later time

Sounds good 👍

justin-curtis-lu · 2023-01-09T17:32:55Z

/integrate

openjdk · 2023-01-09T17:35:40Z

@justin-curtis-lu
Your change (at version cf833ae) is now ready to be sponsored by a Committer.

naotoj · 2023-01-09T17:42:14Z

/sponsor

openjdk · 2023-01-09T17:43:43Z

Going to push as commit cd10c72.
Since your change was applied there have been 59 commits pushed to the master branch:

bfd5971: 8299757: Update JCov version to 3.0.14
17a3f0e: 8299275: Add some ClassLoaderData verification code
4ba8122: 8299312: Clean up BarrierSetNMethod
66db0bb: 8299692: G1: Remove unused G1BlockOffsetTable::is_card_boundary
7068457: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options
500c3c1: 8298730: Refactor subsystem_file_line_contents and add docs and tests
4072412: 8298876: Swing applications do not get repainted coming out of sleep on Windows 10
a503ec2: 8299608: Add Register + imm32 orq to x86_64 assembler
d2827ec: 8299671: speed up compiler/intrinsics/string/TestStringLatin1IndexOfChar.java
05a0a71: 8297933: [REDO] Compiler should only use verified interface types for optimization
... and 49 more: https://git.openjdk.org/jdk/compare/44be5edf5aa661169c665aa9386e5930a3632524...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-01-09T17:44:02Z

@naotoj @justin-curtis-lu Pushed as commit cd10c72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

justin-curtis-lu added 2 commits January 6, 2023 09:33

Fix MessageFormat

1dc3fe9

Fix ChoiceFormat

d633265

openjdk bot added the rfr Pull request is ready for review label Jan 6, 2023

openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 6, 2023

naotoj approved these changes Jan 6, 2023

View reviewed changes

Remove objs=null

cf833ae

openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2023

LanceAndersen approved these changes Jan 6, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2023

openjdk bot added the integrated Pull request has been integrated label Jan 9, 2023

openjdk bot closed this Jan 9, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs #11884

8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs #11884

justin-curtis-lu commented Jan 6, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 6, 2023

openjdk bot commented Jan 6, 2023

mlbridge bot commented Jan 6, 2023 •

edited

Loading

naotoj left a comment

naotoj Jan 6, 2023 •

edited

Loading

justin-curtis-lu Jan 6, 2023

openjdk bot commented Jan 6, 2023 •

edited

Loading

LanceAndersen left a comment

justin-curtis-lu commented Jan 6, 2023

justin-curtis-lu commented Jan 9, 2023

openjdk bot commented Jan 9, 2023

naotoj commented Jan 9, 2023

openjdk bot commented Jan 9, 2023

openjdk bot commented Jan 9, 2023

8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs #11884

8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs #11884

Conversation

justin-curtis-lu commented Jan 6, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jan 6, 2023

openjdk bot commented Jan 6, 2023

mlbridge bot commented Jan 6, 2023 • edited Loading

Webrevs

naotoj left a comment

Choose a reason for hiding this comment

naotoj Jan 6, 2023 • edited Loading

Choose a reason for hiding this comment

justin-curtis-lu Jan 6, 2023

Choose a reason for hiding this comment

openjdk bot commented Jan 6, 2023 • edited Loading

LanceAndersen left a comment

Choose a reason for hiding this comment

justin-curtis-lu commented Jan 6, 2023

justin-curtis-lu commented Jan 9, 2023

openjdk bot commented Jan 9, 2023

naotoj commented Jan 9, 2023

openjdk bot commented Jan 9, 2023

openjdk bot commented Jan 9, 2023

justin-curtis-lu commented Jan 6, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Jan 6, 2023 •

edited

Loading

naotoj Jan 6, 2023 •

edited

Loading

openjdk bot commented Jan 6, 2023 •

edited

Loading