Skip to content

8298735: Some tools/jpackage/windows/* tests fails with jtreg test timeout #11914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Jan 9, 2023

Increase failed test timeouts.
Simple tests got an x1.5 increase and parametrized tests got an x2 increase


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298735: Some tools/jpackage/windows/* tests fails with jtreg test timeout

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11914/head:pull/11914
$ git checkout pull/11914

Update a local copy of the PR:
$ git checkout pull/11914
$ git pull https://git.openjdk.org/jdk pull/11914/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11914

View PR using the GUI difftool:
$ git pr show -t 11914

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11914.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2023

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2023
@openjdk
Copy link

openjdk bot commented Jan 9, 2023

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 9, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298735: Some tools/jpackage/windows/* tests fails with jtreg test timeout

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • 195f313: 8287925: AArch64: intrinsics for compareUnsigned method in Integer and Long
  • 3a66737: 8299525: RISC-V: Add backend support for half float conversion intrinsics
  • b7eb4e2: 8297306: Incorrect brackets in Javadoc for a constructor of IteratorSpliterator
  • a638663: 8255119: Monitor::wait takes signed integer as timeout
  • 4395578: Merge
  • d49851a: 8299689: Make use of JLine for Console as "opt-in"
  • f79b3d4: 6381945: (cal) Japanese calendar unit test system should avoid multiple static imports
  • f36f135: 8299501: Usage of constructors of primitive wrapper classes should be avoided in java.util API docs
  • b8852f6: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs
  • 679e485: 8043251: Bogus javac error: required: no arguments, found: no arguments
  • ... and 48 more: https://git.openjdk.org/jdk/compare/a49ccb959b7e50ee67b1ab4feca47c34bdbc14fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2023
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

Going to push as commit 3c99e78.
Since your change was applied there have been 67 commits pushed to the master branch:

  • 5a51ef2: 8297874: get_dump_directory() in jfrEmergencyDump.cpp should pass correct length to jio_snprintf
  • a86b6f6: 8299183: Invokers.checkExactType passes parameters to create WMTE in opposite order
  • 8b0133f: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE
  • d68de02: 8299845: Remove obsolete comments in DirtyCardToOopClosure::get_actual_top
  • debe587: 8298381: Improve handling of session tickets for multiple SSLContexts
  • eab1e62: 8297487: G1 Remark: no need to keep alive oop constants of nmethods on stack
  • c8a8388: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • 5f37cbe: 8297572: Remove unused PrecisionStyle::Precise
  • f95346e: 8299261: Clean up AWT D3D exports
  • 195f313: 8287925: AArch64: intrinsics for compareUnsigned method in Integer and Long
  • ... and 57 more: https://git.openjdk.org/jdk/compare/a49ccb959b7e50ee67b1ab4feca47c34bdbc14fe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2023
@openjdk openjdk bot closed this Jan 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@alexeysemenyukoracle Pushed as commit 3c99e78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants