8299956: [BACKOUT] 8297487: G1 Remark: no need to keep alive oop constants of nmethods on stack

[TobiHartmann]

Clean backout after we observed various crashes with different tests after the integration of JDK-8297487.

Thanks,
Tobias

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299956: [BACKOUT] 8297487: G1 Remark: no need to keep alive oop constants of nmethods on stack

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11941/head:pull/11941
$ git checkout pull/11941

Update a local copy of the PR:
$ git checkout pull/11941
$ git pull https://git.openjdk.org/jdk pull/11941/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11941

View PR using the GUI difftool:
$ git pr show -t 11941

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11941.diff

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[chhagedorn]

Looks good and trivial.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299956: [BACKOUT] 8297487: G1 Remark: no need to keep alive oop constants of nmethods on stack

Reviewed-by: chagedorn, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Thanks for the quick review, Christian!

[mlbridge]

Webrevs

• 00: Full (f8c8ff2f)

[TobiHartmann]

Thanks Thomas. I'll push this after the sanity testing passed.

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit d15285f.

[openjdk]

@TobiHartmann Pushed as commit d15285f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.