Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8299971: Remove metaprogramming/conditional.hpp #11946

Closed
wants to merge 1 commit into from

Conversation

jcking
Copy link
Contributor

@jcking jcking commented Jan 11, 2023

Code cleanup of pre-C++11 <type_traits> implementations.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11946/head:pull/11946
$ git checkout pull/11946

Update a local copy of the PR:
$ git checkout pull/11946
$ git pull https://git.openjdk.org/jdk pull/11946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11946

View PR using the GUI difftool:
$ git pr show -t 11946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11946.diff

Signed-off-by: Justin King <jcking@google.com>
@jcking
Copy link
Contributor Author

jcking commented Jan 11, 2023

@kimbarrett Yet more cleanup.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2023

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 11, 2023
@openjdk
Copy link

openjdk bot commented Jan 11, 2023

@jcking The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 11, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299971: Remove metaprogramming/conditional.hpp

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • 3ffc955: 8300099: Configuration fails to auto-detect build user through $USER in dockers
  • e7fa150: 8299032: Interface IN_NATIVE oop stores for C2
  • c250222: 8300110: Unproblemlist Fuzz.java from ProblemList-zgc.txt
  • ac63f5f: 8297877: Risk for uninitialized memory in case of CHECK macro early return as part of field access
  • be8e6d0: 8299957: Enhance error logging in instrument coding with additional jplis_assert_msg
  • 640eff6: 8300040: TypeOopPtr::make_from_klass_common calls itself with args in wrong order
  • 19628e3: 8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC
  • 9887047: Merge
  • 4b92fb0: 8299918: Update Xcode11.3.1-MacOSX10.15 devkit at Oracle
  • 6a4a874: 8299034: Runtime::exec clarification of inherited environment
  • ... and 31 more: https://git.openjdk.org/jdk/compare/d15285f948c5414028790e25b4497d28775eeb54...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tschatzl, @kimbarrett) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2023
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jcking
Copy link
Contributor Author

jcking commented Jan 13, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@jcking
Your change (at version a8c41dc) is now ready to be sponsored by a Committer.

@kimbarrett
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

Going to push as commit 4c1e66e.
Since your change was applied there have been 71 commits pushed to the master branch:

  • 4073b68: 8298047: Remove all non-significant trailing whitespace from properties files
  • 506c818: 8296401: ConcurrentHashTable::bulk_delete might miss to delete some objects
  • 319de6a: 8300124: Remove unnecessary assert in GenCollectedHeap::initialize
  • 289aed4: 8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug
  • a2f6766: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
  • a734285: 8299879: CollectedHeap hierarchy should use override
  • 98d75f1: 8299038: Add AArch64 backend support for auto-vectorized FP16 conversions
  • cac72a6: 8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc
  • 6fea233: 8299960: Speed up test/hotspot/jtreg/compiler/c2/irTests/TestVectorizeURShiftSubword.java
  • 7c1ebcc: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java
  • ... and 61 more: https://git.openjdk.org/jdk/compare/d15285f948c5414028790e25b4497d28775eeb54...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2023
@openjdk openjdk bot closed this Jan 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 16, 2023
@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@kimbarrett @jcking Pushed as commit 4c1e66e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants