Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc #11970

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 12, 2023

$ CONF=linux-x86_64-server-fastdebug make test TEST=jdk/internal/vm/Continuation/BasicExt.java TEST_VM_OPTS="-XX:+UseShenandoahGC"

# Internal Error (/home/shade/trunks/jdk/src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp:479), pid=406430, tid=406562
# assert(GCCause::is_user_requested_gc(cause) || GCCause::is_serviceability_requested_gc(cause) || cause == GCCause::_metadata_GC_clear_soft_refs || cause == GCCause::_codecache_GC_aggressive || cause == GCCause::_codecache_GC_threshold || cause == GCCause::_full_gc_alot || cause == GCCause::_wb_full_gc || cause == GCCause::_wb_breakpoint || cause == GCCause::_scavenge_alot) failed: only requested GCs here: WhiteBox Initiated Young GC
#

Added a missing cause into the assert. The test starts to pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11970/head:pull/11970
$ git checkout pull/11970

Update a local copy of the PR:
$ git checkout pull/11970
$ git pull https://git.openjdk.org/jdk pull/11970/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11970

View PR using the GUI difftool:
$ git pr show -t 11970

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11970.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@shipilev The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023

Webrevs

Copy link
Contributor

@earthling-amzn earthling-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to handle wb_young_gc appropriately for Shenandoah's generational mode.

Copy link
Contributor

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc

Reviewed-by: wkemper, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • 6fea233: 8299960: Speed up test/hotspot/jtreg/compiler/c2/irTests/TestVectorizeURShiftSubword.java
  • 7c1ebcc: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java
  • abfd7e8: 8300113: C2: Single-bit fields with signed type in TypePtr after JDK-8297933
  • 83f2c9a: 8293410: Remove GenerateRangeChecks flag
  • 50e7df9: 8300024: Replace use of JNI_COMMIT mode with mode 0
  • fe7fca0: 8300032: DwarfParser resource leak
  • 12edd6f: 8300052: PdhDll::PdhCollectQueryData and PdhLookupPerfNameByIndex will never be NULL
  • 7bcd5f4: 8297914: Remove java_lang_Class::process_archived_mirror()
  • 4be94e4: Merge
  • 87865e0: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs
  • ... and 25 more: https://git.openjdk.org/jdk/compare/7a85d95e828283d57e1df0344be454626470675d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 16, 2023
@shipilev
Copy link
Member Author

Thank you!

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2023

Going to push as commit cac72a6.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 6fea233: 8299960: Speed up test/hotspot/jtreg/compiler/c2/irTests/TestVectorizeURShiftSubword.java
  • 7c1ebcc: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java
  • abfd7e8: 8300113: C2: Single-bit fields with signed type in TypePtr after JDK-8297933
  • 83f2c9a: 8293410: Remove GenerateRangeChecks flag
  • 50e7df9: 8300024: Replace use of JNI_COMMIT mode with mode 0
  • fe7fca0: 8300032: DwarfParser resource leak
  • 12edd6f: 8300052: PdhDll::PdhCollectQueryData and PdhLookupPerfNameByIndex will never be NULL
  • 7bcd5f4: 8297914: Remove java_lang_Class::process_archived_mirror()
  • 4be94e4: Merge
  • 87865e0: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs
  • ... and 25 more: https://git.openjdk.org/jdk/compare/7a85d95e828283d57e1df0344be454626470675d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2023
@openjdk openjdk bot closed this Jan 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2023
@openjdk
Copy link

openjdk bot commented Jan 16, 2023

@shipilev Pushed as commit cac72a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
3 participants