Skip to content

8300054: Use static_assert in basic_types_init #11971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8300054: Use static_assert in basic_types_init #11971

wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 12, 2023 •
edited by openjdk bot
Loading

Simple change to use static_assert when applicable inside a function.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11971/head:pull/11971
$ git checkout pull/11971

Update a local copy of the PR:
$ git checkout pull/11971
$ git pull https://git.openjdk.org/jdk pull/11971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11971

View PR using the GUI difftool:
$ git pr show -t 11971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11971.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8300054 8300054: Use static_assert in basic_types_init Jan 12, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 12, 2023
@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023 •
edited
Loading

Webrevs

stefank
stefank approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@stefank stefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One nit:

stefank
stefank reviewed Jan 12, 2023
View reviewed changes
src/hotspot/share/utilities/globalDefinitions.cpp Outdated
Comment on lines 160 to 162
static_assert((size_t)HeapWordSize >= sizeof(juint),
"HeapWord should be at least as large as juint");
assert(sizeof(NULL) == sizeof(char*), "NULL must be same size as pointer");
static_assert(sizeof(NULL) == sizeof(char*), "NULL must be same size as pointer");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fix alignment here.

@openjdk
Copy link

openjdk bot commented Jan 12, 2023 •
edited
Loading

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300054: Use static_assert in basic_types_init

Reviewed-by: stefank, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 33412c1: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • 7a85d95: 8298448: UndefinedBehaviorSanitizer
  • 26890d1: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH
  • cf00d09: 8299330: Minor improvements in MSYS2 Workflow handling
  • 48c8fb3: 8299978: Remove MethodHandleNatives.getMembers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 12, 2023
kimbarrett
kimbarrett approved these changes Jan 12, 2023
View reviewed changes
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

Going to push as commit d117979.
Since your change was applied there have been 18 commits pushed to the master branch:

  • ce1193a: 8299976: Initialize static fields in Net eagerly
  • 3ffc955: 8300099: Configuration fails to auto-detect build user through $USER in dockers
  • e7fa150: 8299032: Interface IN_NATIVE oop stores for C2
  • c250222: 8300110: Unproblemlist Fuzz.java from ProblemList-zgc.txt
  • ac63f5f: 8297877: Risk for uninitialized memory in case of CHECK macro early return as part of field access
  • be8e6d0: 8299957: Enhance error logging in instrument coding with additional jplis_assert_msg
  • 640eff6: 8300040: TypeOopPtr::make_from_klass_common calls itself with args in wrong order
  • 19628e3: 8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC
  • 9887047: Merge
  • 4b92fb0: 8299918: Update Xcode11.3.1-MacOSX10.15 devkit at Oracle
  • ... and 8 more: https://git.openjdk.org/jdk/compare/89d3f3d96b220c249e7b273a09cc3897428f8814...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2023
@openjdk openjdk bot closed this Jan 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@albertnetymk Pushed as commit d117979.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the static-assert branch January 13, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefank stefank stefank approved these changes

@kimbarrett kimbarrett kimbarrett approved these changes

Assignees
No one assigned
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertnetymk @stefank @kimbarrett