8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows

[naotoj]

Fixing a regression caused by the fix to JDK-8298971. The previous fix lacked the native part change on Windows.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11973/head:pull/11973
$ git checkout pull/11973

Update a local copy of the PR:
$ git checkout pull/11973
$ git pull https://git.openjdk.org/jdk pull/11973/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11973

View PR using the GUI difftool:
$ git pr show -t 11973

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11973.diff

[bridgekeeper]

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@naotoj The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7b8e41db)
• 00: Full (ee2ac0e7)

[AlanBateman]

I think we should try to have a cleaner separation between these native methods. If JdkConsoleImpl_echo is changed to call GetStdHandle(STD_INPUT_HANDLE) then it would avoid needing Console_md to export java_io_Console_hStdIn. It would mean the static fields in Console_md could be removed too.

[naotoj]

I think we should try to have a cleaner separation between these native methods. If JdkConsoleImpl_echo is changed to call GetStdHandle(STD_INPUT_HANDLE) then it would avoid needing Console_md to export java_io_Console_hStdIn. It would mean the static fields in Console_md could be removed too.

Thanks, Alan. Modified the code not to share the handles.

[openjdk]

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• 4be94e4: Merge
• 87865e0: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs
• dc5cc61: 8299499: Usage of constructors of primitive wrapper classes should be avoided in java.net API docs
• 98eae6d: 8299500: Usage of constructors of primitive wrapper classes should be avoided in java.text API docs
• 628266a: 8299501: Usage of constructors of primitive wrapper classes should be avoided in java.util API docs
• ab7f43f: 8299498: Usage of constructors of primitive wrapper classes should be avoided in java.lang API docs
• bc498f8: 8300141: ProblemList java/util/concurrent/locks/Lock/OOMEInAQS.java with ZGC
• e008146: 8300055: [BACKOUT] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE
• f4e119d: 8300012: Remove unused JDI VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) method
• 8cb25d3: 8298644: JNI call of getCurrentComponent on a wrong thread
• ... and 40 more: https://git.openjdk.org/jdk/compare/d663b5da10be1f3f33a2729e4b3605fb5e13b4d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[naotoj]

/integrate

[openjdk]

Going to push as commit e7e3712.
Since your change was applied there have been 87 commits pushed to the master branch:

• 0b9ff06: 8300184: Optimize ResourceHashtableBase::iterate_all using _number_of_entries
• 75b122f: 8300120: Configure should support different defaults for CI/dev build environments
• e139ec3: 8300069: Left shift of negative value in share/adlc/dict2.cpp
• fb147aa: 8300228: ModuleReader.find on exploded module throws if resource name maps to invalid file path
• 4cd166f: 8300125: Serial: Remove unused Generation::reset_saved_marks
• 85d70ac: Merge
• e15bdc5: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
• b7fb8ef: 8299323: Allow extended registers for cmpw
• 07d5753: 8300168: Typo in AccessibleJTableHeaderEntry javadoc
• e82dc69: 8300205: Swing test bug8078268 make latch timeout configurable
• ... and 77 more: https://git.openjdk.org/jdk/compare/d663b5da10be1f3f33a2729e4b3605fb5e13b4d6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj Pushed as commit e7e3712.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.