Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300055: [BACKOUT] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE #11974

Closed
wants to merge 1 commit into from

Conversation

gerard-ziemski
Copy link

@gerard-ziemski gerard-ziemski commented Jan 12, 2023

This is a backout (using git revert) of JDK-8291060 OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE which triggered a bug in ksh, resulting in a crash.

Verified with test case from https://bugs.openjdk.org/browse/JDK-8299258 and currently running Mach5 hs-tier1,2,3,4,5.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300055: [BACKOUT] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11974/head:pull/11974
$ git checkout pull/11974

Update a local copy of the PR:
$ git checkout pull/11974
$ git pull https://git.openjdk.org/jdk pull/11974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11974

View PR using the GUI difftool:
$ git pr show -t 11974

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11974.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2023

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 12, 2023

@gerard-ziemski The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 12, 2023
@gerard-ziemski gerard-ziemski marked this pull request as ready for review January 12, 2023 17:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 12, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2023

Webrevs

@coleenp
Copy link
Contributor

coleenp commented Jan 12, 2023

@gerard-ziemski you need to do this on JDK 20.

@gerard-ziemski
Copy link
Author

Right, thank you Coleen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review
2 participants